[PM-21033] Implement signing key migration
đī¸ Tracking
https://bitwarden.atlassian.net/browse/PM-21033
đ Objective
This PR handles local state handling of signing keys, and the upgrade path to signing keys.
Note: The build fails because an SDK change still needs to be merged. However, the rest of the PR is reviewable.
đ¸ Screenshots
â° Reminders before review
- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team
đĻŽ Reviewer guidelines
- đ (
:+1:) or similar for great changes - đ (
:memo:) or âšī¸ (:information_source:) for notes or general info - â (
:question:) for questions - đ¤ (
:thinking:) or đ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - đ¨ (
:art:) for suggestions / improvements - â (
:x:) or â ī¸ (:warning:) for more significant problems or concerns needing attention - đą (
:seedling:) or âģī¸ (:recycle:) for future improvements or indications of technical debt - â (
:pick:) for minor or nitpick changes
Checkmarx One â Scan Summary & Details â 6aab053a-94fa-479d-922b-7331a7161036
Great job! No new security vulnerabilities introduced in this pull request
Codecov Report
:x: Patch coverage is 64.95726% with 82 lines in your changes missing coverage. Please review.
:white_check_mark: Project coverage is 38.90%. Comparing base (d17fa04) to head (24f8b5b).
:warning: Report is 13 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #14942 +/- ##
==========================================
+ Coverage 38.86% 38.90% +0.03%
==========================================
Files 3419 3435 +16
Lines 97259 97460 +201
Branches 14611 14648 +37
==========================================
+ Hits 37802 37918 +116
- Misses 57798 57879 +81
- Partials 1659 1663 +4
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Could you add some test coverage to:
libs/common/src/platform/sync/default-sync.service.ts- No coverage forinitialize_user_cryptoapps/web/src/app/key-management/key-rotation/user-key-rotation.service.ts- No coverage whenEnrollAeadOnKeyRotationis enabled
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.2% Duplication on New Code
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
0.2% Duplication on New Code
Changes in this PR impact the Autofill experience of the browser client
BIT has tested the core experience with these changes and all feature flags disabled.
â Fortunately, these BIT tests have passed! đ
Changes in this PR impact the Autofill experience of the browser client
BIT has tested the core experience with these changes and the feature flag configuration used by vault.bitwarden.com.
â Fortunately, these BIT tests have passed! đ