clients icon indicating copy to clipboard operation
clients copied to clipboard

[PM-12048] Wire up vNextCollectionService

Open BTreston opened this issue 7 months ago â€ĸ 3 comments

đŸŽŸī¸ Tracking

https://bitwarden.atlassian.net/browse/PM-12048 https://bitwarden.atlassian.net/browse/PM-14247 https://bitwarden.atlassian.net/browse/PM-14247 https://bitwarden.atlassian.net/browse/PM-22538

📔 Objective

Wires up vNextCollectionService and removes old implementation.

📸 Screenshots

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

đŸĻŽ Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or â„šī¸ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or âš ī¸ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or â™ģī¸ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

BTreston avatar May 21 '25 20:05 BTreston

Logo Checkmarx One – Scan Summary & Details – 7bdd414a-2e57-4b76-bbf2-9166cbe088b9

Fixed Issues (5)

Great job! The following issues were fixed in this Pull Request

Severity Issue Source File / Package
HIGH ~~Relative_Path_Traversal~~ /apps/cli/src/oss-serve-configurator.ts: 374
HIGH ~~Relative_Path_Traversal~~ /apps/cli/src/oss-serve-configurator.ts: 374
MEDIUM ~~Insecure_Storage_of_Sensitive_Data~~ /apps/cli/src/commands/get.command.ts: 402
MEDIUM ~~Insecure_Storage_of_Sensitive_Data~~ /apps/cli/src/commands/get.command.ts: 403
MEDIUM ~~Insecure_Storage_of_Sensitive_Data~~ /apps/cli/src/commands/get.command.ts: 387

github-actions[bot] avatar May 21 '25 20:05 github-actions[bot]

Codecov Report

Attention: Patch coverage is 42.23301% with 119 lines in your changes missing coverage. Please review.

Project coverage is 37.60%. Comparing base (fe1c040) to head (2c4dada). Report is 3 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...collections/services/default-collection.service.ts 72.85% 14 Missing and 5 partials :warning:
.../src/app/vault/individual-vault/vault.component.ts 0.00% 17 Missing :warning:
...n-console/organizations/manage/groups.component.ts 0.00% 11 Missing :warning:
...console/organizations/members/members.component.ts 0.00% 9 Missing :warning:
apps/cli/src/commands/list.command.ts 0.00% 8 Missing :warning:
...src/autofill/background/notification.background.ts 0.00% 6 Missing :warning:
.../desktop/src/vault/app/vault/vault-v2.component.ts 0.00% 6 Missing :warning:
...s/collection-dialog/collection-dialog.component.ts 0.00% 6 Missing :warning:
...port-core/src/services/org-vault-export.service.ts 0.00% 6 Missing :warning:
...assign-collections/assign-collections.component.ts 0.00% 4 Missing :warning:
... and 14 more
Additional details and impacted files
@@           Coverage Diff           @@
##             main   #14871   +/-   ##
=======================================
  Coverage   37.59%   37.60%           
=======================================
  Files        3322     3320    -2     
  Lines       94923    94889   -34     
  Branches    14361    14357    -4     
=======================================
- Hits        35687    35679    -8     
+ Misses      57738    57705   -33     
- Partials     1498     1505    +7     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar May 21 '25 20:05 codecov[bot]

That is a minor issue on a test file â˜ī¸ so you can pass this back to QA in the meantime if you like.

eliykat avatar Jul 17 '25 01:07 eliykat