[PM-12048] Wire up vNextCollectionService
đī¸ Tracking
https://bitwarden.atlassian.net/browse/PM-12048 https://bitwarden.atlassian.net/browse/PM-14247 https://bitwarden.atlassian.net/browse/PM-14247 https://bitwarden.atlassian.net/browse/PM-22538
đ Objective
Wires up vNextCollectionService and removes old implementation.
đ¸ Screenshots
â° Reminders before review
- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team
đĻŽ Reviewer guidelines
- đ (
:+1:) or similar for great changes - đ (
:memo:) or âšī¸ (:information_source:) for notes or general info - â (
:question:) for questions - đ¤ (
:thinking:) or đ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - đ¨ (
:art:) for suggestions / improvements - â (
:x:) or â ī¸ (:warning:) for more significant problems or concerns needing attention - đą (
:seedling:) or âģī¸ (:recycle:) for future improvements or indications of technical debt - â (
:pick:) for minor or nitpick changes
Checkmarx One â Scan Summary & Details â 7bdd414a-2e57-4b76-bbf2-9166cbe088b9
Fixed Issues (5)
Great job! The following issues were fixed in this Pull Request
| Severity | Issue | Source File / Package |
|---|---|---|
![]() |
~~Relative_Path_Traversal~~ | /apps/cli/src/oss-serve-configurator.ts: 374 |
![]() |
~~Relative_Path_Traversal~~ | /apps/cli/src/oss-serve-configurator.ts: 374 |
![]() |
~~Insecure_Storage_of_Sensitive_Data~~ | /apps/cli/src/commands/get.command.ts: 402 |
![]() |
~~Insecure_Storage_of_Sensitive_Data~~ | /apps/cli/src/commands/get.command.ts: 403 |
![]() |
~~Insecure_Storage_of_Sensitive_Data~~ | /apps/cli/src/commands/get.command.ts: 387 |
Codecov Report
Attention: Patch coverage is 42.23301% with 119 lines in your changes missing coverage. Please review.
Project coverage is 37.60%. Comparing base (
fe1c040) to head (2c4dada). Report is 3 commits behind head on main.
:white_check_mark: All tests successful. No failed tests found.
Additional details and impacted files
@@ Coverage Diff @@
## main #14871 +/- ##
=======================================
Coverage 37.59% 37.60%
=======================================
Files 3322 3320 -2
Lines 94923 94889 -34
Branches 14361 14357 -4
=======================================
- Hits 35687 35679 -8
+ Misses 57738 57705 -33
- Partials 1498 1505 +7
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
:rocket: New features to boost your workflow:
- :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
That is a minor issue on a test file âī¸ so you can pass this back to QA in the meantime if you like.
Quality Gate passed
Issues
0 New issues
0 Accepted issues
Measures
0 Security Hotspots
0.0% Coverage on New Code
4.2% Duplication on New Code

