[PM-18721][PM-21272] Integrate InputPasswordComponent in AccountRecoveryDialogComponent

[rr-bw]

🎟️ Tracking

PM-18721 PM-21272

This PR stacks on top of these two PRs:

• https://github.com/bitwarden/clients/pull/14636
• https://github.com/bitwarden/clients/pull/14226

📔 Objective

This PR integrates the InputPasswordComponent within the AccountRecoveryDialogComponent (formerly called ResetPasswordComponent).

The result is that:

• The InputPasswordComponent will now handle form field UI display and validation that is common to all of our set/change password flows
• The AccountRecoveryDialogComponent will now just be responsible for displaying the dialog and calling resetPasswordService.resetMasterPassword() to perform the password reset operation.

The showing of the new dialog component is behind the PM16117_ChangeExistingPasswordRefactor feature flag.

📸 Screenshots

PM16117_ChangeExistingPasswordRefactor flag ON ✅

https://github.com/user-attachments/assets/45a82faf-668a-45d7-a6ea-131f13df03f3

PM16117_ChangeExistingPasswordRefactor flag OFF ❌

https://github.com/user-attachments/assets/4fe07143-0608-4fe9-8cb5-cf8ec88b1cc8

⏰ Reminders before review

• Contributor guidelines followed
• All formatters and local linters executed and passed
• Written new unit and / or integration tests where applicable
• Protected functional changes with optionality (feature flags)
• Used internationalization (i18n) for all UI strings
• CI builds passed
• Communicated to DevOps any deployment requirements
• Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

• 👍 (:+1:) or similar for great changes
• 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
• ❓ (:question:) for questions
• 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
• 🎨 (:art:) for suggestions / improvements
• ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
• 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
• ⛏ (:pick:) for minor or nitpick changes

[codecov[bot]]

Codecov Report

Attention: Patch coverage is 0% with 54 lines in your changes missing coverage. Please review.

Project coverage is 36.84%. Comparing base (9ba3cc0) to head (185c300). Report is 4 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
...ount-recovery/account-recovery-dialog.component.ts	0.00%	36 Missing :warning:
...console/organizations/members/members.component.ts	0.00%	12 Missing :warning:
...angular/input-password/input-password.component.ts	0.00%	4 Missing :warning:
...app/admin-console/common/base-members.component.ts	0.00%	1 Missing :warning:
...tions/members/components/account-recovery/index.ts	0.00%	1 Missing :warning:

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #14662      +/-   ##
==========================================
- Coverage   36.85%   36.84%   -0.02%     
==========================================
  Files        3228     3230       +2     
  Lines       93388    93438      +50     
  Branches    14056    14062       +6     
==========================================
+ Hits        34419    34426       +7     
- Misses      57543    57586      +43     
  Partials     1426     1426              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:

• :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[github-actions[bot]]

Checkmarx One – Scan Summary & Details – e5c5651f-ba1e-4854-9a5b-9a9f277fd526

Great job, no security vulnerabilities found in this Pull Request

[pamperer562580892423]

Mere mortal user here again. - I don't know if it's intentional, but the password generator component in the "Recover account" dialog (shown in the first 20 seconds of the video) doesn't contain a "Check for Data breaches"-button, like it is shown and available in the browser extension after a password was generated:

[rr-bw]

@eliykat

What's the plan for managing your branches - are they being merged into main one-at-a-time in order, or are they all getting merged down into a single feature branch? I ask because usually feature flags remove the need for large feature branches.

• https://github.com/bitwarden/clients/pull/14662 (This PR)
  • Will be merged to main directly, after PM-14636 has been merged, because it doesn't have meaningful changes outside of the feature flag
• https://github.com/bitwarden/clients/pull/14636
  • Will be tested on a feature branch because it has meaningful changes that leak outside the feature flag
• https://github.com/bitwarden/clients/pull/14226
  • Has been merged to main and fully tested

[rr-bw]

Mere mortal user here again. - I don't know if it's intentional, but the password generator component in the "Recover account" dialog (shown in the first 20 seconds of the video) doesn't contain a "Check for Data breaches"-button, like it is shown and available in the browser extension after a password was generated:

Thanks again! @pamperer562580892423

I've raised the question to our Product team.

[pamperer562580892423]

Mere mortal user here again. - I don't know if it's intentional, but the password generator component in the "Recover account" dialog (shown in the first 20 seconds of the video) doesn't contain a "Check for Data breaches"-button, like it is shown and available in the browser extension after a password was generated:

Thanks again! @pamperer562580892423

I've raised the question to our Product team.

Thanks for that "update"! - And I think you have also seen by now, that the "Data breach checker" is also missing in the "Update Master Password" dialog (second part of the video).

[sonarqubecloud[bot]]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud