clients icon indicating copy to clipboard operation
clients copied to clipboard

[PM-14939] devices list view for browser

Open alec-livefront opened this issue 8 months ago â€ĸ 3 comments

đŸŽŸī¸ Tracking

PM-14939

📔 Objective

Creates a new DeviceManagementComponent that fetches devices and formats them before handing them off to a view component for display.

View components:

  • DeviceManagementTableComponent - displays on medium to large screens
  • DeviceManagementItemGroupComponent - displays on small screens

📸 Screenshots

Extension - Item Group view

https://github.com/user-attachments/assets/9a9593a5-660d-43eb-9a55-8bd4904d2bc2

Web - Table view

https://github.com/user-attachments/assets/1c00c8fc-2db3-4c21-b6b8-ec90ea4dbdaa

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

đŸĻŽ Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or â„šī¸ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or âš ī¸ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or â™ģī¸ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

alec-livefront avatar May 05 '25 03:05 alec-livefront

Codecov Report

Attention: Patch coverage is 4.51977% with 169 lines in your changes missing coverage. Please review.

Project coverage is 37.44%. Comparing base (127fed7) to head (4723c66). Report is 2 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...h/device-management/device-management.component.ts 0.00% 83 Missing :warning:
...ce-management/device-management-table.component.ts 0.00% 22 Missing :warning:
...rc/auth/device-management/resort-devices.helper.ts 0.00% 19 Missing :warning:
...nagement/device-management-item-group.component.ts 0.00% 16 Missing :warning:
...services/devices/devices.service.implementation.ts 0.00% 11 Missing :warning:
.../settings/extension-device-management.component.ts 0.00% 7 Missing :warning:
.../auth/settings/security/security-routing.module.ts 0.00% 3 Missing :warning:
...s/extension-device-management-component.service.ts 0.00% 2 Missing :warning:
apps/browser/src/popup/services/services.module.ts 0.00% 2 Missing :warning:
...ent/default-device-management-component.service.ts 0.00% 2 Missing :warning:
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14620      +/-   ##
==========================================
- Coverage   37.51%   37.44%   -0.08%     
==========================================
  Files        3303     3310       +7     
  Lines       93958    94107     +149     
  Branches    14132    14165      +33     
==========================================
- Hits        35249    35239      -10     
- Misses      57249    57408     +159     
  Partials     1460     1460              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

:rocket: New features to boost your workflow:
  • :package: JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

codecov[bot] avatar May 05 '25 03:05 codecov[bot]

Logo Checkmarx One – Scan Summary & Details – f05b7086-a796-453b-a832-a1f509ebc719

Great job, no security vulnerabilities found in this Pull Request

github-actions[bot] avatar May 05 '25 03:05 github-actions[bot]