[PM-13769] - fix routing for send created page
đī¸ Tracking
https://bitwarden.atlassian.net/browse/PM-13769
đ Objective
This PR fixes the routing logic for the send created page. Clicking the back arrow should go to the edit form, and after saving the form should go back to the send list. Clicking "close" in the send created page should also go back to the send list.
đ¸ Screenshots
â° Reminders before review
- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team
đĻŽ Reviewer guidelines
- đ (
:+1:) or similar for great changes - đ (
:memo:) or âšī¸ (:information_source:) for notes or general info - â (
:question:) for questions - đ¤ (
:thinking:) or đ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - đ¨ (
:art:) for suggestions / improvements - â (
:x:) or â ī¸ (:warning:) for more significant problems or concerns needing attention - đą (
:seedling:) or âģī¸ (:recycle:) for future improvements or indications of technical debt - â (
:pick:) for minor or nitpick changes
Checkmarx One â Scan Summary & Details â 13c20f55-0576-4321-bcdc-0fc39f48a55f
New Issues
| Severity | Issue | Source File / Package | Checkmarx Insight |
|---|---|---|---|
![]() |
Angular_Improper_Type_Pipe_Usage | /libs/tools/generator/components/src/username-generator.component.html: 45 | Attack Vector |
![]() |
Angular_Improper_Type_Pipe_Usage | /libs/tools/generator/components/src/username-generator.component.html: 30 | Attack Vector |
![]() |
Angular_Improper_Type_Pipe_Usage | /libs/tools/generator/components/src/username-generator.component.html: 30 | Attack Vector |
![]() |
Angular_Improper_Type_Pipe_Usage | /libs/tools/generator/components/src/username-generator.component.html: 35 | Attack Vector |
![]() |
Angular_Improper_Type_Pipe_Usage | /libs/tools/generator/components/src/username-generator.component.html: 40 | Attack Vector |
![]() |
Client_Privacy_Violation | /apps/web/src/app/tools/access-intelligence/password-health-members.component.ts: 58 | Attack Vector |
![]() |
Client_Privacy_Violation | /apps/web/src/app/tools/access-intelligence/password-health-members.component.ts: 56 | Attack Vector |
![]() |
Client_Privacy_Violation | /apps/web/src/app/tools/access-intelligence/password-health-members.component.ts: 52 | Attack Vector |
![]() |
Client_Privacy_Violation | /apps/web/src/app/tools/access-intelligence/password-health-members.component.html: 46 | Attack Vector |
![]() |
Client_Privacy_Violation | /libs/vault/src/components/password-history-view/password-history-view.component.html: 6 | Attack Vector |
![]() |
Client_Privacy_Violation | /libs/vault/src/components/password-history-view/password-history-view.component.ts: 37 | Attack Vector |
![]() |
Client_Privacy_Violation | /libs/vault/src/components/password-history-view/password-history-view.component.ts: 37 | Attack Vector |
![]() |
Client_Privacy_Violation | /libs/vault/src/components/password-history-view/password-history-view.component.ts: 37 | Attack Vector |
![]() |
Client_Privacy_Violation | /libs/vault/src/components/password-history-view/password-history-view.component.ts: 37 | Attack Vector |
![]() |
Client_Privacy_Violation | /libs/tools/generator/components/src/password-generator.component.html: 8 | Attack Vector |
![]() |
Client_Privacy_Violation | /libs/tools/generator/components/src/password-generator.component.html: 8 | Attack Vector |
![]() |
Client_Privacy_Violation | /libs/tools/generator/components/src/password-generator.component.html: 14 | Attack Vector |
![]() |
Client_Privacy_Violation | /apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 809 | Attack Vector |
![]() |
Client_Privacy_Violation | /apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 820 | Attack Vector |
![]() |
Client_Privacy_Violation | /apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 780 | Attack Vector |
![]() |
Client_Privacy_Violation | /libs/tools/generator/components/src/username-generator.component.html: 3 | Attack Vector |
Fixed Issues
| Severity | Issue | Source File / Package |
|---|---|---|
![]() |
Client_Privacy_Violation | /libs/vault/src/components/password-history-view/password-history-view.component.html: 6 |
![]() |
Client_Privacy_Violation | /libs/vault/src/components/password-history-view/password-history-view.component.html: 6 |
![]() |
Client_Privacy_Violation | /apps/web/src/app/tools/access-intelligence/password-health-members.component.html: 51 |
![]() |
Client_Privacy_Violation | /apps/web/src/app/tools/access-intelligence/password-health-members.component.html: 46 |
![]() |
Client_Privacy_Violation | /apps/web/src/app/tools/access-intelligence/password-health-members.component.html: 41 |
![]() |
Client_Privacy_Violation | /apps/web/src/app/tools/access-intelligence/password-health-members.component.html: 46 |
![]() |
Client_Privacy_Violation | /apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 781 |
![]() |
Client_Privacy_Violation | /apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 781 |
![]() |
Client_Privacy_Violation | /apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 780 |
![]() |
Client_Privacy_Violation | /libs/tools/generator/components/src/username-generator.component.html: 3 |
![]() |
Client_Privacy_Violation | /apps/browser/src/vault/popup/components/vault/password-history.component.html: 18 |
![]() |
Client_Privacy_Violation | /apps/browser/src/vault/popup/components/vault/password-history.component.html: 18 |
Codecov Report
Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
Project coverage is 33.26%. Comparing base (
77c5086) to head (6eb44b9). Report is 1 commits behind head on main.
:white_check_mark: All tests successful. No failed tests found.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| .../popup/send-v2/add-edit/send-add-edit.component.ts | 0.00% | 1 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #11629 +/- ##
==========================================
- Coverage 33.27% 33.26% -0.01%
==========================================
Files 2789 2789
Lines 86669 86670 +1
Branches 16506 16506
==========================================
- Hits 28835 28828 -7
- Misses 55539 55547 +8
Partials 2295 2295
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
