[PM-13813] - fix voiceover on send created screen
đī¸ Tracking
https://bitwarden.atlassian.net/browse/PM-13813
đ Objective
This PR fixes an issue where screen readers weren't reading the send created success text. Adding an autofocus and tabindex allows for the text to be focused.
As a bonus autofocus was also added to the name input in the the send details form to improve the ux
đ¸ Screenshots
â° Reminders before review
- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team
đĻŽ Reviewer guidelines
- đ (
:+1:) or similar for great changes - đ (
:memo:) or âšī¸ (:information_source:) for notes or general info - â (
:question:) for questions - đ¤ (
:thinking:) or đ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - đ¨ (
:art:) for suggestions / improvements - â (
:x:) or â ī¸ (:warning:) for more significant problems or concerns needing attention - đą (
:seedling:) or âģī¸ (:recycle:) for future improvements or indications of technical debt - â (
:pick:) for minor or nitpick changes
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 33.28%. Comparing base (
4768f7c) to head (6005a76). Report is 18 commits behind head on main.
:white_check_mark: All tests successful. No failed tests found.
Additional details and impacted files
@@ Coverage Diff @@
## main #11628 +/- ##
==========================================
+ Coverage 33.24% 33.28% +0.04%
==========================================
Files 2783 2785 +2
Lines 86529 86561 +32
Branches 16488 16490 +2
==========================================
+ Hits 28766 28813 +47
+ Misses 55473 55453 -20
- Partials 2290 2295 +5
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Checkmarx One â Scan Summary & Details â d06bf0eb-73e8-437e-85fb-5df42176cdc6
New Issues
| Severity | Issue | Source File / Package | Checkmarx Insight |
|---|---|---|---|
![]() |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/password-history.component.ts: 63 | Attack Vector |
![]() |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/password-history.component.ts: 63 | Attack Vector |
![]() |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/password-history.component.ts: 63 | Attack Vector |
![]() |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/password-history.component.ts: 63 | Attack Vector |
![]() |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/password-history.component.html: 11 | Attack Vector |
![]() |
Client_Privacy_Violation | /apps/web/src/app/vault/individual-vault/password-history.component.html: 11 | Attack Vector |
Fixed Issues
| Severity | Issue | Source File / Package |
|---|---|---|
![]() |
Client_Privacy_Violation | /libs/vault/src/components/password-history-view/password-history-view.component.html: 6 |
![]() |
Client_Privacy_Violation | /libs/vault/src/components/password-history-view/password-history-view.component.html: 6 |
![]() |
Client_Privacy_Violation | /apps/browser/src/vault/popup/components/vault/password-history.component.html: 18 |
![]() |
Client_Privacy_Violation | /apps/browser/src/vault/popup/components/vault/password-history.component.html: 18 |
