clients
clients copied to clipboard
bitwarden
[PM-12996] Updating UI Spacing for bit section header
đī¸ Tracking
https://bitwarden.atlassian.net/browse/PM-12996
đ Objective
Update UI to have more spacing to the left of the header where it's off.
đ¸ Screenshots
â° Reminders before review
- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team
đĻŽ Reviewer guidelines
- đ (
:+1:) or similar for great changes - đ (
:memo:) or âšī¸ (:information_source:) for notes or general info - â (
:question:) for questions - đ¤ (
:thinking:) or đ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - đ¨ (
:art:) for suggestions / improvements - â (
:x:) or â ī¸ (:warning:) for more significant problems or concerns needing attention - đą (
:seedling:) or âģī¸ (:recycle:) for future improvements or indications of technical debt - â (
:pick:) for minor or nitpick changes
Checkmarx One â Scan Summary & Details â 3afd53c6-f353-4df7-8b28-70fb0f854f81
New Issues
| Severity | Issue | Source File / Package | Checkmarx Insight |
|---|---|---|---|
 |
Client_Privacy_Violation | /apps/browser/src/vault/popup/components/vault-v2/vault-list-items-container/vault-list-items-container.component.html: 15 | Attack Vector |
|
Client_Privacy_Violation | /apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 781 | Attack Vector |
|
Client_Privacy_Violation | /apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 781 | Attack Vector |
|
Client_Privacy_Violation | /apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 780 | Attack Vector |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 187 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /publish-desktop.yml: 122 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /build-browser.yml: 367 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 523 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /build-cli.yml: 405 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /build-web.yml: 267 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /build-desktop.yml: 1293 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 180 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /retrieve-current-desktop-rollout.yml: 23 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /crowdin-pull.yml: 35 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /publish-desktop.yml: 245 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /publish-web.yml: 44 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 247 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /build-desktop.yml: 288 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /version-auto-bump.yml: 21 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 82 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 515 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 201 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /build-desktop.yml: 1339 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /crowdin-pull.yml: 41 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 194 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /publish-cli.yml: 104 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /build-desktop.yml: 891 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 297 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 48 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /build-web.yml: 191 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /staged-rollout-desktop.yml: 29 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 359 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /build-web.yml: 297 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 499 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 507 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /publish-desktop.yml: 196 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /build-browser.yml: 408 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /brew-bump-desktop.yml: 26 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 162 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /publish-cli.yml: 141 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /build-web.yml: 342 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /publish-cli.yml: 181 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
 |
Unpinned Actions Full Length Commit SHA | /publish-cli.yml: 141 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /build-desktop.yml: 1293 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /publish-cli.yml: 104 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /build-desktop.yml: 1339 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 162 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 507 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 180 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /publish-desktop.yml: 196 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /build-desktop.yml: 891 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /build-desktop.yml: 288 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /build-browser.yml: 367 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 247 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /retrieve-current-desktop-rollout.yml: 23 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 297 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /publish-desktop.yml: 122 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /build-browser.yml: 408 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 187 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 515 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /publish-cli.yml: 181 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /build-cli.yml: 405 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 201 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 499 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 82 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 523 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 359 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /publish-web.yml: 44 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 48 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 194 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
|
Unpinned Actions Full Length Commit SHA | /publish-desktop.yml: 245 | Pinning an action to a full length commit SHA is currently the only way to use an action as an immutable release. Pinning to a particular SHA helps... |
Fixed Issues
| Severity | Issue | Source File / Package |
|---|---|---|
|
Client_Privacy_Violation | /apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 809 |
|
Client_Privacy_Violation | /apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 820 |
|
Client_Privacy_Violation | /apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 780 |
|
Client_Privacy_Violation | /apps/browser/src/vault/popup/components/vault-v2/vault-list-items-container/vault-list-items-container.component.html: 14 |
|
Unpinned Actions Full Length Commit SHA | /publish-cli.yml: 103 |
|
Unpinned Actions Full Length Commit SHA | /publish-desktop.yml: 121 |
|
Unpinned Actions Full Length Commit SHA | /publish-desktop.yml: 244 |
|
Unpinned Actions Full Length Commit SHA | /build-desktop.yml: 1292 |
|
Unpinned Actions Full Length Commit SHA | /build-desktop.yml: 890 |
|
Unpinned Actions Full Length Commit SHA | /staged-rollout-desktop.yml: 28 |
|
Unpinned Actions Full Length Commit SHA | /publish-cli.yml: 180 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 246 |
|
Unpinned Actions Full Length Commit SHA | /build-web.yml: 341 |
|
Unpinned Actions Full Length Commit SHA | /build-desktop.yml: 287 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 47 |
|
Unpinned Actions Full Length Commit SHA | /version-auto-bump.yml: 20 |
|
Unpinned Actions Full Length Commit SHA | /publish-web.yml: 43 |
|
Unpinned Actions Full Length Commit SHA | /crowdin-pull.yml: 34 |
|
Unpinned Actions Full Length Commit SHA | /build-desktop.yml: 1338 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 498 |
|
Unpinned Actions Full Length Commit SHA | /build-web.yml: 296 |
|
Unpinned Actions Full Length Commit SHA | /build-web.yml: 266 |
|
Unpinned Actions Full Length Commit SHA | /publish-cli.yml: 140 |
|
Unpinned Actions Full Length Commit SHA | /brew-bump-desktop.yml: 25 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 193 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 186 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 358 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 296 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 506 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 200 |
|
Unpinned Actions Full Length Commit SHA | /crowdin-pull.yml: 40 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 161 |
|
Unpinned Actions Full Length Commit SHA | /retrieve-current-desktop-rollout.yml: 22 |
|
Unpinned Actions Full Length Commit SHA | /build-browser.yml: 366 |
|
Unpinned Actions Full Length Commit SHA | /build-web.yml: 190 |
|
Unpinned Actions Full Length Commit SHA | /build-browser.yml: 407 |
|
Unpinned Actions Full Length Commit SHA | /publish-desktop.yml: 195 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 179 |
|
Unpinned Actions Full Length Commit SHA | /build-cli.yml: 404 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 522 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 514 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 81 |
|
Unpinned Actions Full Length Commit SHA | /publish-web.yml: 43 |
|
Unpinned Actions Full Length Commit SHA | /publish-cli.yml: 180 |
|
Unpinned Actions Full Length Commit SHA | /publish-cli.yml: 140 |
|
Unpinned Actions Full Length Commit SHA | /version-auto-bump.yml: 20 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 186 |
|
Unpinned Actions Full Length Commit SHA | /publish-desktop.yml: 195 |
|
Unpinned Actions Full Length Commit SHA | /publish-cli.yml: 103 |
|
Unpinned Actions Full Length Commit SHA | /build-desktop.yml: 1292 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 522 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 506 |
|
Unpinned Actions Full Length Commit SHA | /staged-rollout-desktop.yml: 28 |
|
Unpinned Actions Full Length Commit SHA | /build-cli.yml: 404 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 514 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 161 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 179 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 81 |
|
Unpinned Actions Full Length Commit SHA | /build-web.yml: 266 |
|
Unpinned Actions Full Length Commit SHA | /crowdin-pull.yml: 40 |
|
Unpinned Actions Full Length Commit SHA | /publish-desktop.yml: 121 |
|
Unpinned Actions Full Length Commit SHA | /brew-bump-desktop.yml: 25 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 200 |
|
Unpinned Actions Full Length Commit SHA | /build-browser.yml: 366 |
|
Unpinned Actions Full Length Commit SHA | /build-browser.yml: 407 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 246 |
|
Unpinned Actions Full Length Commit SHA | /crowdin-pull.yml: 34 |
|
Unpinned Actions Full Length Commit SHA | /build-desktop.yml: 890 |
|
Unpinned Actions Full Length Commit SHA | /retrieve-current-desktop-rollout.yml: 22 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 358 |
|
Unpinned Actions Full Length Commit SHA | /build-desktop.yml: 1338 |
|
Unpinned Actions Full Length Commit SHA | /publish-desktop.yml: 244 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 47 |
|
Unpinned Actions Full Length Commit SHA | /build-web.yml: 296 |
|
Unpinned Actions Full Length Commit SHA | /build-web.yml: 190 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 498 |
|
Unpinned Actions Full Length Commit SHA | /build-web.yml: 341 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 296 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 193 |
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 33.20%. Comparing base (
a72f3a2) to head (b634eb3). Report is 60 commits behind head on main.
:white_check_mark: All tests successful. No failed tests found.
Additional details and impacted files
@@ Coverage Diff @@
## main #11609 +/- ##
=======================================
Coverage 33.19% 33.20%
=======================================
Files 2780 2782 +2
Lines 86411 86484 +73
Branches 16469 16484 +15
=======================================
+ Hits 28688 28714 +26
- Misses 55438 55483 +45
- Partials 2285 2287 +2
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}