clients icon indicating copy to clipboard operation
clients copied to clipboard

[PM-13729] Show toast when copying SCIM api key and URL

Open BTreston opened this issue 1 year ago • 2 comments

🎟️ Tracking

PM-13729

📔 Objective

This PR adds calls to the toast service to show success toasts when copying a SCIM api key or URL.

📸 Screenshots

Screenshot 2024-10-17 at 2 38 37 PM Screenshot 2024-10-17 at 2 38 32 PM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

BTreston avatar Oct 17 '24 18:10 BTreston

Logo Checkmarx One – Scan Summary & Details12d8eb1f-f038-4cc1-ac77-72572f9deb02

No New Or Fixed Issues Found

github-actions[bot] avatar Oct 17 '24 18:10 github-actions[bot]

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 33.20%. Comparing base (1d10f34) to head (9fb00fb). Report is 88 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...min-console/organizations/manage/scim.component.ts 0.00% 2 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11608      +/-   ##
==========================================
- Coverage   33.20%   33.20%   -0.01%     
==========================================
  Files        2782     2782              
  Lines       86484    86486       +2     
  Branches    16484    16484              
==========================================
  Hits        28721    28721              
- Misses      55476    55478       +2     
  Partials     2287     2287              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 17 '24 18:10 codecov[bot]