Auth/pm 8115/desktop extension UI refresh self hosted
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-8115?atlOrigin=eyJpIjoiZjYxZDhiNjg1OWQwNDFlZGI3NWQyYmVkYTZlMGVhNGYiLCJwIjoiaiJ9
📔 Objective
Uses the new RegistrationSelfHostedEnvConfigDialogComponent as the dialog when selecting "self-hosted" from the server configuration on the login page. Also adjusts the leading text for the select based on whether the UnauthenticatedExtensionUIRefresh is enabled.
📸 Screenshots
⏰ Reminders before review
- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team
🦮 Reviewer guidelines
- 👍 (
:+1:) or similar for great changes - 📝 (
:memo:) or ℹ️ (:information_source:) for notes or general info - ❓ (
:question:) for questions - 🤔 (
:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (
:art:) for suggestions / improvements - ❌ (
:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention - 🌱 (
:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt - ⛏ (
:pick:) for minor or nitpick changes
Codecov Report
Attention: Patch coverage is 0% with 32 lines in your changes missing coverage. Please review.
Project coverage is 33.54%. Comparing base (
9a83509) to head (e451b4e). Report is 2 commits behind head on main.
:white_check_mark: All tests successful. No failed tests found.
Additional details and impacted files
@@ Coverage Diff @@
## main #11597 +/- ##
==========================================
- Coverage 33.55% 33.54% -0.01%
==========================================
Files 2810 2810
Lines 87296 87319 +23
Branches 16644 16655 +11
==========================================
Hits 29288 29288
- Misses 55712 55735 +23
Partials 2296 2296
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Checkmarx One – Scan Summary & Details – 0d62f7c6-35d5-4fdd-9adb-f2cd580d4ba6
Fixed Issues
| Severity | Issue | Source File / Package |
|---|---|---|
![]() |
Client_Privacy_Violation | /libs/tools/generator/components/src/credential-generator-history.component.html: 6 |
![]() |
Client_Privacy_Violation | /apps/web/src/app/tools/access-intelligence/password-health.component.html: 50 |
![]() |
Client_Privacy_Violation | /apps/web/src/app/tools/access-intelligence/password-health.component.html: 45 |
![]() |
Client_Privacy_Violation | /apps/web/src/app/tools/access-intelligence/password-health.component.html: 40 |
![]() |
Client_Privacy_Violation | /apps/web/src/app/tools/access-intelligence/password-health.component.html: 45 |
![]() |
Client_Privacy_Violation | /apps/web/src/app/tools/access-intelligence/password-health-members.component.html: 72 |
![]() |
Client_Privacy_Violation | /apps/web/src/app/tools/access-intelligence/password-health-members.component.html: 77 |
![]() |
Client_Privacy_Violation | /apps/web/src/app/tools/access-intelligence/password-health-members.component.html: 72 |
![]() |
Client_Privacy_Violation | /apps/web/src/app/tools/access-intelligence/password-health-members.component.html: 67 |
![]() |
Client_Privacy_Violation | /libs/tools/generator/components/src/username-generator.component.html: 3 |
@JaredSnider-Bitwarden I believe I've implemented everything we talked about this morning:
- Moving / renaming the
SelfHostedEnvConfigDialogComponent - Removing the EnvironmentSelectorService
- Removing the instance of "loggingInOn" from browser messages
