clients icon indicating copy to clipboard operation
clients copied to clipboard

Auth/pm 8115/desktop extension UI refresh self hosted

Open alec-livefront opened this issue 1 year ago • 2 comments

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-8115?atlOrigin=eyJpIjoiZjYxZDhiNjg1OWQwNDFlZGI3NWQyYmVkYTZlMGVhNGYiLCJwIjoiaiJ9

📔 Objective

Uses the new RegistrationSelfHostedEnvConfigDialogComponent as the dialog when selecting "self-hosted" from the server configuration on the login page. Also adjusts the leading text for the select based on whether the UnauthenticatedExtensionUIRefresh is enabled.

📸 Screenshots

Screenshot 2024-10-16 at 9 28 34 PM Screenshot 2024-10-16 at 9 28 24 PM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

alec-livefront avatar Oct 17 '24 02:10 alec-livefront

Codecov Report

Attention: Patch coverage is 0% with 32 lines in your changes missing coverage. Please review.

Project coverage is 33.54%. Comparing base (9a83509) to head (e451b4e). Report is 2 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
.../auth/components/environment-selector.component.ts 0.00% 15 Missing :warning:
...-dialog/self-hosted-env-config-dialog.component.ts 0.00% 14 Missing :warning:
...nv-selector/registration-env-selector.component.ts 0.00% 2 Missing :warning:
libs/auth/src/angular/index.ts 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11597      +/-   ##
==========================================
- Coverage   33.55%   33.54%   -0.01%     
==========================================
  Files        2810     2810              
  Lines       87296    87319      +23     
  Branches    16644    16655      +11     
==========================================
  Hits        29288    29288              
- Misses      55712    55735      +23     
  Partials     2296     2296              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 17 '24 02:10 codecov[bot]

Logo Checkmarx One – Scan Summary & Details0d62f7c6-35d5-4fdd-9adb-f2cd580d4ba6

Fixed Issues

Severity Issue Source File / Package
MEDIUM Client_Privacy_Violation /libs/tools/generator/components/src/credential-generator-history.component.html: 6
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health.component.html: 50
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health.component.html: 45
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health.component.html: 40
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health.component.html: 45
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health-members.component.html: 72
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health-members.component.html: 77
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health-members.component.html: 72
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health-members.component.html: 67
MEDIUM Client_Privacy_Violation /libs/tools/generator/components/src/username-generator.component.html: 3

github-actions[bot] avatar Oct 17 '24 02:10 github-actions[bot]

@JaredSnider-Bitwarden I believe I've implemented everything we talked about this morning:

  • Moving / renaming the SelfHostedEnvConfigDialogComponent
  • Removing the EnvironmentSelectorService
  • Removing the instance of "loggingInOn" from browser messages

alec-livefront avatar Oct 28 '24 19:10 alec-livefront