clients
clients copied to clipboard
[PM-13454] - Health report raw data and member count to uri
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-13454
📔 Objective
This PR adds a new component that displays the list of ciphers split up by host.
📸 Screenshots
⏰ Reminders before review
- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team
🦮 Reviewer guidelines
- 👍 (
:+1:) or similar for great changes - 📝 (
:memo:) or ℹ️ (:information_source:) for notes or general info - ❓ (
:question:) for questions - 🤔 (
:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (
:art:) for suggestions / improvements - ❌ (
:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention - 🌱 (
:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt - ⛏ (
:pick:) for minor or nitpick changes
Checkmarx One – Scan Summary & Details – 48b7e6bf-7e6a-4842-8a9c-35762f123fac
New Issues
| Severity | Issue | Source File / Package | Checkmarx Insight |
|---|---|---|---|
![]() |
Client_Privacy_Violation | /apps/web/src/app/tools/access-intelligence/password-health-members-uri.component.html: 44 | Attack Vector |
![]() |
Client_Privacy_Violation | /apps/web/src/app/tools/access-intelligence/password-health-members-uri.component.html: 39 | Attack Vector |
![]() |
Client_Privacy_Violation | /apps/web/src/app/tools/access-intelligence/password-health-members-uri.component.html: 34 | Attack Vector |
![]() |
Client_Privacy_Violation | /apps/web/src/app/tools/access-intelligence/password-health-members-uri.component.html: 39 | Attack Vector |
![]() |
Client_Privacy_Violation | /apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 809 | Attack Vector |
![]() |
Client_Privacy_Violation | /apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 820 | Attack Vector |
![]() |
Client_Privacy_Violation | /apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 780 | Attack Vector |
![]() |
Client_Privacy_Violation | /apps/web/src/app/vault/components/vault-items/vault-cipher-row.component.html: 31 | Attack Vector |
![]() |
Client_Privacy_Violation | /apps/web/src/app/vault/components/vault-items/vault-cipher-row.component.html: 53 | Attack Vector |
![]() |
Client_Privacy_Violation | /libs/tools/generator/components/src/username-generator.component.html: 3 | Attack Vector |
Fixed Issues
| Severity | Issue | Source File / Package |
|---|---|---|
![]() |
Client_Privacy_Violation | /apps/browser/src/autofill/popup/settings/autofill.component.html: 104 |
![]() |
Client_Privacy_Violation | /apps/browser/src/autofill/popup/settings/autofill.component.html: 79 |
![]() |
Client_Privacy_Violation | /apps/web/src/app/vault/components/vault-items/vault-cipher-row.component.ts: 18 |
![]() |
Client_Privacy_Violation | /apps/web/src/app/vault/components/vault-items/vault-cipher-row.component.ts: 18 |
![]() |
Client_Privacy_Violation | /apps/web/src/app/vault/components/vault-items/vault-cipher-row.component.ts: 18 |
![]() |
Client_Privacy_Violation | /apps/web/src/app/vault/components/vault-items/vault-cipher-row.component.ts: 18 |
![]() |
Client_Privacy_Violation | /apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 781 |
![]() |
Client_Privacy_Violation | /apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 781 |
![]() |
Client_Privacy_Violation | /apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 780 |
![]() |
Client_Privacy_Violation | /libs/tools/send/send-ui/src/send-form/components/options/send-options.component.ts: 52 |
Codecov Report
Attention: Patch coverage is 33.67876% with 128 lines in your changes missing coverage. Please review.
Project coverage is 33.19%. Comparing base (
d70d2cb) to head (4473874). Report is 48 commits behind head on main.
:white_check_mark: All tests successful. No failed tests found.
Additional details and impacted files
@@ Coverage Diff @@
## main #11596 +/- ##
========================================
Coverage 33.19% 33.19%
========================================
Files 2780 2783 +3
Lines 86410 86603 +193
Branches 16469 16512 +43
========================================
+ Hits 28681 28751 +70
- Misses 55444 55555 +111
- Partials 2285 2297 +12
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
