clients icon indicating copy to clipboard operation
clients copied to clipboard

[PM-13454] - Health report raw data and member count to uri

Open jaasen-livefront opened this issue 1 year ago • 2 comments

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-13454

📔 Objective

This PR adds a new component that displays the list of ciphers split up by host.

📸 Screenshots

Screenshot 2024-10-16 at 4 57 39 PM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

jaasen-livefront avatar Oct 16 '24 23:10 jaasen-livefront

Logo Checkmarx One – Scan Summary & Details48b7e6bf-7e6a-4842-8a9c-35762f123fac

New Issues

Severity Issue Source File / Package Checkmarx Insight
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health-members-uri.component.html: 44 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health-members-uri.component.html: 39 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health-members-uri.component.html: 34 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/tools/access-intelligence/password-health-members-uri.component.html: 39 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 809 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 820 Attack Vector
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 780 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/components/vault-items/vault-cipher-row.component.html: 31 Attack Vector
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/components/vault-items/vault-cipher-row.component.html: 53 Attack Vector
MEDIUM Client_Privacy_Violation /libs/tools/generator/components/src/username-generator.component.html: 3 Attack Vector

Fixed Issues

Severity Issue Source File / Package
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/popup/settings/autofill.component.html: 104
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/popup/settings/autofill.component.html: 79
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/components/vault-items/vault-cipher-row.component.ts: 18
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/components/vault-items/vault-cipher-row.component.ts: 18
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/components/vault-items/vault-cipher-row.component.ts: 18
MEDIUM Client_Privacy_Violation /apps/web/src/app/vault/components/vault-items/vault-cipher-row.component.ts: 18
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 781
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 781
MEDIUM Client_Privacy_Violation /apps/browser/src/autofill/overlay/inline-menu/pages/list/autofill-inline-menu-list.ts: 780
MEDIUM Client_Privacy_Violation /libs/tools/send/send-ui/src/send-form/components/options/send-options.component.ts: 52

github-actions[bot] avatar Oct 17 '24 00:10 github-actions[bot]

Codecov Report

Attention: Patch coverage is 33.67876% with 128 lines in your changes missing coverage. Please review.

Project coverage is 33.19%. Comparing base (d70d2cb) to head (4473874). Report is 48 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...elligence/password-health-members-uri.component.ts 0.00% 88 Missing :warning:
...-intelligence/password-health-members.component.ts 63.36% 26 Missing and 11 partials :warning:
...cess-intelligence/access-intelligence.component.ts 0.00% 2 Missing :warning:
libs/common/src/vault/models/view/cipher.view.ts 0.00% 1 Missing :warning:
Additional details and impacted files
@@           Coverage Diff            @@
##             main   #11596    +/-   ##
========================================
  Coverage   33.19%   33.19%            
========================================
  Files        2780     2783     +3     
  Lines       86410    86603   +193     
  Branches    16469    16512    +43     
========================================
+ Hits        28681    28751    +70     
- Misses      55444    55555   +111     
- Partials     2285     2297    +12     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 17 '24 00:10 codecov[bot]