clients icon indicating copy to clipboard operation
clients copied to clipboard

[PM-13651] migrate verify recover delete provider component

Open BTreston opened this issue 1 year ago • 2 comments

🎟️ Tracking

PM-13651

📔 Objective

This PR refactors the VerifyRecoverDeleteProvider component to use the component library and removes bootstrap classes from the templates. It also removes the VerifyRecoverDeleteProvider and the Providers components out of the loose-components.module and into their own domain specific module.

📸 Screenshots

Before: Screenshot 2024-10-16 at 11 45 42 AM

After: Screenshot 2024-10-17 at 12 25 40 PM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

BTreston avatar Oct 16 '24 18:10 BTreston

Logo Checkmarx One – Scan Summary & Details38ea88ef-268d-4d15-88d2-ca2b26c4e05d

No New Or Fixed Issues Found

github-actions[bot] avatar Oct 16 '24 18:10 github-actions[bot]

Codecov Report

Attention: Patch coverage is 0% with 11 lines in your changes missing coverage. Please review.

Project coverage is 33.54%. Comparing base (85194fd) to head (3586baa). Report is 23 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...viders/verify-recover-delete-provider.component.ts 0.00% 5 Missing :warning:
...rden_license/bit-web/src/app/app-routing.module.ts 0.00% 3 Missing :warning:
...rc/app/admin-console/providers/providers.module.ts 0.00% 2 Missing :warning:
...dmin-console/providers/providers-routing.module.ts 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11586      +/-   ##
==========================================
- Coverage   33.55%   33.54%   -0.01%     
==========================================
  Files        2808     2808              
  Lines       87233    87229       -4     
  Branches    16646    16644       -2     
==========================================
- Hits        29271    29261      -10     
- Misses      55644    55657      +13     
+ Partials     2318     2311       -7     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 16 '24 18:10 codecov[bot]