clients
clients copied to clipboard
bitwarden
[PM-13645] Fix invite counter to check remaining number of seats in plan
🎟️ Tracking
📔 Objective
This PR fixes the hint message for the email field when inviting new members to an organization to calculate how many seats remain in an org.
📸 Screenshots
⏰ Reminders before review
- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team
🦮 Reviewer guidelines
- 👍 (
:+1:) or similar for great changes - 📝 (
:memo:) or ℹ️ (:information_source:) for notes or general info - ❓ (
:question:) for questions - 🤔 (
:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (
:art:) for suggestions / improvements - ❌ (
:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention - 🌱 (
:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt - ⛏ (
:pick:) for minor or nitpick changes
Checkmarx One – Scan Summary & Details – 0b872c5c-b031-41f4-b5ab-66de5b0a4359
Fixed Issues
| Severity | Issue | Source File / Package |
|---|---|---|
 |
Client_Privacy_Violation | /apps/web/src/app/tools/access-intelligence/password-health.component.html: 50 |
|
Client_Privacy_Violation | /apps/web/src/app/tools/access-intelligence/password-health.component.html: 45 |
|
Client_Privacy_Violation | /apps/web/src/app/tools/access-intelligence/password-health.component.html: 40 |
|
Client_Privacy_Violation | /apps/web/src/app/tools/access-intelligence/password-health.component.html: 45 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 523 |
|
Unpinned Actions Full Length Commit SHA | /deploy-web.yml: 191 |
|
Unpinned Actions Full Length Commit SHA | /publish-web.yml: 44 |
|
Unpinned Actions Full Length Commit SHA | /release-desktop.yml: 71 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 297 |
|
Unpinned Actions Full Length Commit SHA | /build-desktop.yml: 1339 |
|
Unpinned Actions Full Length Commit SHA | /release-web.yml: 57 |
|
Unpinned Actions Full Length Commit SHA | /publish-desktop.yml: 122 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 499 |
|
Unpinned Actions Full Length Commit SHA | /crowdin-pull.yml: 41 |
|
Unpinned Actions Full Length Commit SHA | /publish-cli.yml: 104 |
|
Unpinned Actions Full Length Commit SHA | /publish-desktop.yml: 245 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 48 |
|
Unpinned Actions Full Length Commit SHA | /release-desktop-beta.yml: 668 |
|
Unpinned Actions Full Length Commit SHA | /release-browser.yml: 96 |
|
Unpinned Actions Full Length Commit SHA | /version-auto-bump.yml: 21 |
|
Unpinned Actions Full Length Commit SHA | /build-web.yml: 342 |
|
Unpinned Actions Full Length Commit SHA | /build-desktop.yml: 891 |
|
Unpinned Actions Full Length Commit SHA | /brew-bump-desktop.yml: 26 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 359 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 201 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 194 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 247 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 82 |
|
Unpinned Actions Full Length Commit SHA | /staged-rollout-desktop.yml: 29 |
|
Unpinned Actions Full Length Commit SHA | /build-web.yml: 297 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 162 |
|
Unpinned Actions Full Length Commit SHA | /publish-desktop.yml: 196 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 180 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 515 |
|
Unpinned Actions Full Length Commit SHA | /crowdin-pull.yml: 35 |
|
Unpinned Actions Full Length Commit SHA | /build-browser.yml: 367 |
|
Unpinned Actions Full Length Commit SHA | /release-desktop.yml: 44 |
|
Unpinned Actions Full Length Commit SHA | /release-desktop-beta.yml: 51 |
|
Unpinned Actions Full Length Commit SHA | /build-browser.yml: 408 |
|
Unpinned Actions Full Length Commit SHA | /publish-cli.yml: 141 |
|
Unpinned Actions Full Length Commit SHA | /release-desktop.yml: 94 |
|
Unpinned Actions Full Length Commit SHA | /release-desktop-beta.yml: 248 |
|
Unpinned Actions Full Length Commit SHA | /release-cli.yml: 59 |
|
Unpinned Actions Full Length Commit SHA | /release-cli.yml: 44 |
|
Unpinned Actions Full Length Commit SHA | /build-desktop.yml: 1293 |
|
Unpinned Actions Full Length Commit SHA | /retrieve-current-desktop-rollout.yml: 23 |
|
Unpinned Actions Full Length Commit SHA | /release-web.yml: 41 |
|
Unpinned Actions Full Length Commit SHA | /publish-cli.yml: 181 |
|
Unpinned Actions Full Length Commit SHA | /build-web.yml: 191 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 187 |
|
Unpinned Actions Full Length Commit SHA | /build-desktop.yml: 288 |
|
Unpinned Actions Full Length Commit SHA | /deploy-web.yml: 222 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 507 |
|
Unpinned Actions Full Length Commit SHA | /release-browser.yml: 44 |
|
Unpinned Actions Full Length Commit SHA | /build-cli.yml: 405 |
|
Unpinned Actions Full Length Commit SHA | /deploy-web.yml: 270 |
|
Unpinned Actions Full Length Commit SHA | /build-web.yml: 267 |
 |
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 82 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 247 |
|
Unpinned Actions Full Length Commit SHA | /build-desktop.yml: 288 |
|
Unpinned Actions Full Length Commit SHA | /build-cli.yml: 405 |
|
Unpinned Actions Full Length Commit SHA | /publish-web.yml: 44 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 201 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 180 |
|
Unpinned Actions Full Length Commit SHA | /build-browser.yml: 367 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 194 |
|
Unpinned Actions Full Length Commit SHA | /publish-desktop.yml: 196 |
|
Unpinned Actions Full Length Commit SHA | /release-desktop-beta.yml: 668 |
|
Unpinned Actions Full Length Commit SHA | /build-desktop.yml: 1293 |
|
Unpinned Actions Full Length Commit SHA | /publish-desktop.yml: 245 |
|
Unpinned Actions Full Length Commit SHA | /build-browser.yml: 408 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 48 |
|
Unpinned Actions Full Length Commit SHA | /publish-desktop.yml: 122 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 359 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 162 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 507 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 523 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 515 |
|
Unpinned Actions Full Length Commit SHA | /publish-cli.yml: 141 |
|
Unpinned Actions Full Length Commit SHA | /build-desktop.yml: 1339 |
|
Unpinned Actions Full Length Commit SHA | /publish-cli.yml: 181 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 499 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 297 |
|
Unpinned Actions Full Length Commit SHA | /retrieve-current-desktop-rollout.yml: 23 |
|
Unpinned Actions Full Length Commit SHA | /build-desktop.yml: 891 |
|
Unpinned Actions Full Length Commit SHA | /version-bump.yml: 187 |
|
Unpinned Actions Full Length Commit SHA | /publish-cli.yml: 104 |
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Codecov Report
Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
Project coverage is 33.19%. Comparing base (
70d83fe) to head (9616c06). Report is 131 commits behind head on main.
:white_check_mark: All tests successful. No failed tests found.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...omponents/member-dialog/member-dialog.component.ts | 0.00% | 2 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #11577 +/- ##
==========================================
+ Coverage 33.16% 33.19% +0.03%
==========================================
Files 2779 2782 +3
Lines 86310 86463 +153
Branches 16445 16477 +32
==========================================
+ Hits 28621 28699 +78
- Misses 55415 55479 +64
- Partials 2274 2285 +11
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
![codecov[bot] avatar](https://avatars.githubusercontent.com/in/254?v=4 "Published by a pub.dev verified publisher"){kind=small}