Delete @types/gulp & @types/minimatch on posinstall
đī¸ Tracking
đ Objective
Seems to work more reliably than the overrides. The root issue should be fixed when https://github.com/electron/asar/pull/332 is merged.
â° Reminders before review
- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team
đĻŽ Reviewer guidelines
- đ (
:+1:) or similar for great changes - đ (
:memo:) or âšī¸ (:information_source:) for notes or general info - â (
:question:) for questions - đ¤ (
:thinking:) or đ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - đ¨ (
:art:) for suggestions / improvements - â (
:x:) or â ī¸ (:warning:) for more significant problems or concerns needing attention - đą (
:seedling:) or âģī¸ (:recycle:) for future improvements or indications of technical debt - â (
:pick:) for minor or nitpick changes
Codecov Report
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 33.17%. Comparing base (
f69e943) to head (52119b5). Report is 88 commits behind head on main.
:white_check_mark: All tests successful. No failed tests found.
Additional details and impacted files
@@ Coverage Diff @@
## main #11509 +/- ##
=======================================
Coverage 33.17% 33.17%
=======================================
Files 2779 2779
Lines 86223 86223
Branches 16420 16420
=======================================
Hits 28604 28604
Misses 55353 55353
Partials 2266 2266
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Checkmarx One â Scan Summary & Details â b9659e39-676c-489c-8df4-ae551bc998bb
No New Or Fixed Issues Found
@MGibson1 I always manually write my merge commits, so a squash won't be needed. At this point I don't see this happening in the near future due to the electron maintainers perspective on the issue.
The auto merge has the following message. "This can be reverted once https://github.com/electron/asar/issues/330 is resolved."