clients icon indicating copy to clipboard operation
clients copied to clipboard

Delete @types/gulp & @types/minimatch on posinstall

Open Hinton opened this issue 1 year ago â€ĸ 4 comments

đŸŽŸī¸ Tracking

📔 Objective

Seems to work more reliably than the overrides. The root issue should be fixed when https://github.com/electron/asar/pull/332 is merged.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

đŸĻŽ Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or â„šī¸ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or âš ī¸ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or â™ģī¸ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Hinton avatar Oct 11 '24 15:10 Hinton

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 33.17%. Comparing base (f69e943) to head (52119b5). Report is 88 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #11509   +/-   ##
=======================================
  Coverage   33.17%   33.17%           
=======================================
  Files        2779     2779           
  Lines       86223    86223           
  Branches    16420    16420           
=======================================
  Hits        28604    28604           
  Misses      55353    55353           
  Partials     2266     2266           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 11 '24 15:10 codecov[bot]

Logo Checkmarx One – Scan Summary & Details – b9659e39-676c-489c-8df4-ae551bc998bb

No New Or Fixed Issues Found

github-actions[bot] avatar Oct 11 '24 15:10 github-actions[bot]

@MGibson1 I always manually write my merge commits, so a squash won't be needed. At this point I don't see this happening in the near future due to the electron maintainers perspective on the issue.

Hinton avatar Oct 17 '24 18:10 Hinton

The auto merge has the following message. "This can be reverted once https://github.com/electron/asar/issues/330 is resolved."

Hinton avatar Oct 17 '24 18:10 Hinton