Last sync time incorrect

[mitrovda]

Steps To Reproduce

1. Somehow prevent network access to the Bitwarden instance (disconnect from Wifi/LAN, block domain on DNS server)
2. Check last sync time under Settings -> Vault -> Sync (and try to manually sync to verify that it's not working)
3. Lock vault
4. Unlock vault
5. Check last sync time under Settings -> Vault -> Sync

Expected Result

The last sync time shouldn't change as the sync couldn't have been successful.

Actual Result

The last sync time changes to the unlock time, event though the sync wasn't successful.

Screenshots or Videos

No response

Additional Context

The sync time doesn't update when it fails after manually syncing, only when unlocking the vault.

Knowing the last sync time can be quite useful in self-hosted environments where the server is not publicly available (e.g. enterprise deployments).

Operating System

Windows

Operating System Version

Windows 10, 11

Web Browser

Chrome, Microsoft Edge

Browser Version

Edge: 129.0.2792.79, Chrome: 128.0.6613.186

Build Version

2024.10.0

Issue Tracking Info

• [x] I understand that work is tracked outside of Github. A PR will be linked to this issue should one be opened to address it, but Bitwarden doesn't use fields like "assigned", "milestone", or "project" to track progress.

[rmcdowell-bitwarden]

Hi there,

Thank you for your report!

I was able to reproduce this issue, and I have flagged this to our engineering team.

If you wish to add any further information/screenshots/recordings etc., please feel free to do so at any time - our engineering team will be happy to review these.

Thanks once again!