clients icon indicating copy to clipboard operation
clients copied to clipboard

[Pm 5237] Clients, Self Hosted: Login - Hide "Create account" when registration disabled

Open alec-livefront opened this issue 1 year ago • 2 comments

🎟️ Tracking

https://bitwarden.atlassian.net/browse/PM-5237?atlOrigin=eyJpIjoiZjU0YjVmYTU0MzYwNDZmNzliOThkNjFhZWUwZjNjODgiLCJwIjoiaiJ9

📔 Objective

Adds a ServerSettingsService which allows us to access disableUserRegistration from GlobalSettings. This allows us to check whether user registration is disabled and hide the "Create account" link.

📸 Screenshots

Screenshot 2024-10-04 at 12 40 23 PM

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

🦮 Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or ℹ️ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

alec-livefront avatar Oct 04 '24 17:10 alec-livefront

Codecov Report

Attention: Patch coverage is 21.28146% with 344 lines in your changes missing coverage. Please review.

Project coverage is 33.26%. Comparing base (801d9a8) to head (bc06033).

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
libs/auth/src/angular/login/login.component.ts 0.00% 219 Missing :warning:
.../src/auth/login/desktop-login-component.service.ts 42.42% 13 Missing and 6 partials :warning:
libs/auth/src/angular/index.ts 0.00% 14 Missing :warning:
...core/services/login/web-login-component.service.ts 66.66% 4 Missing and 9 partials :warning:
...r/src/auth/functions/unauth-ui-refresh-redirect.ts 0.00% 12 Missing :warning:
...angular/login/login-secondary-content.component.ts 0.00% 11 Missing :warning:
apps/browser/src/popup/services/services.module.ts 0.00% 6 Missing :warning:
apps/desktop/src/app/services/services.module.ts 0.00% 5 Missing :warning:
...registration-start/registration-start.component.ts 0.00% 5 Missing :warning:
...n/src/platform/services/server-settings.service.ts 0.00% 5 Missing :warning:
... and 19 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11418      +/-   ##
==========================================
- Coverage   33.31%   33.26%   -0.06%     
==========================================
  Files        2787     2800      +13     
  Lines       86620    87024     +404     
  Branches    16525    16619      +94     
==========================================
+ Hits        28859    28947      +88     
- Misses      55458    55755     +297     
- Partials     2303     2322      +19     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 04 '24 17:10 codecov[bot]

Logo Checkmarx One – Scan Summary & Details711e8af0-2953-45ad-b1ae-ab4610096dbb

Fixed Issues

Severity Issue Source File / Package
LOW Client_JQuery_Deprecated_Symbols /apps/cli/src/service-container/service-container.ts: 875

github-actions[bot] avatar Oct 04 '24 17:10 github-actions[bot]