[Pm 5237] Clients, Self Hosted: Login - Hide "Create account" when registration disabled
🎟️ Tracking
https://bitwarden.atlassian.net/browse/PM-5237?atlOrigin=eyJpIjoiZjU0YjVmYTU0MzYwNDZmNzliOThkNjFhZWUwZjNjODgiLCJwIjoiaiJ9
📔 Objective
Adds a ServerSettingsService which allows us to access disableUserRegistration from GlobalSettings. This allows us to check whether user registration is disabled and hide the "Create account" link.
📸 Screenshots
⏰ Reminders before review
- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team
🦮 Reviewer guidelines
- 👍 (
:+1:) or similar for great changes - 📝 (
:memo:) or ℹ️ (:information_source:) for notes or general info - ❓ (
:question:) for questions - 🤔 (
:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - 🎨 (
:art:) for suggestions / improvements - ❌ (
:x:) or ⚠️ (:warning:) for more significant problems or concerns needing attention - 🌱 (
:seedling:) or ♻️ (:recycle:) for future improvements or indications of technical debt - ⛏ (
:pick:) for minor or nitpick changes
Codecov Report
Attention: Patch coverage is 21.28146% with 344 lines in your changes missing coverage. Please review.
Project coverage is 33.26%. Comparing base (
801d9a8) to head (bc06033).
:white_check_mark: All tests successful. No failed tests found.
Additional details and impacted files
@@ Coverage Diff @@
## main #11418 +/- ##
==========================================
- Coverage 33.31% 33.26% -0.06%
==========================================
Files 2787 2800 +13
Lines 86620 87024 +404
Branches 16525 16619 +94
==========================================
+ Hits 28859 28947 +88
- Misses 55458 55755 +297
- Partials 2303 2322 +19
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Checkmarx One – Scan Summary & Details – 711e8af0-2953-45ad-b1ae-ab4610096dbb
Fixed Issues
| Severity | Issue | Source File / Package |
|---|---|---|
![]() |
Client_JQuery_Deprecated_Symbols | /apps/cli/src/service-container/service-container.ts: 875 |
