clients
clients copied to clipboard
[PM-13113] - account for potential null config in SendFilePopoutDialogContainerComponent
đī¸ Tracking
https://bitwarden.atlassian.net/browse/PM-13113
đ Objective
This PR attempts to fix the issue of the extension window closing after selecting a file in the file send.
đ¸ Screenshots
â° Reminders before review
- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team
đĻŽ Reviewer guidelines
- đ (
:+1:) or similar for great changes - đ (
:memo:) or âšī¸ (:information_source:) for notes or general info - â (
:question:) for questions - đ¤ (
:thinking:) or đ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - đ¨ (
:art:) for suggestions / improvements - â (
:x:) or â ī¸ (:warning:) for more significant problems or concerns needing attention - đą (
:seedling:) or âģī¸ (:recycle:) for future improvements or indications of technical debt - â (
:pick:) for minor or nitpick changes
Codecov Report
Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.
Project coverage is 33.25%. Comparing base (
d1c3a98) to head (1c4bb24). Report is 168 commits behind head on main.
:white_check_mark: All tests successful. No failed tests found.
| Files with missing lines | Patch % | Lines |
|---|---|---|
| ...log/send-file-popout-dialog-container.component.ts | 0.00% | 2 Missing :warning: |
Additional details and impacted files
@@ Coverage Diff @@
## main #11372 +/- ##
==========================================
- Coverage 33.26% 33.25% -0.01%
==========================================
Files 2728 2728
Lines 85412 85413 +1
Branches 16277 16278 +1
==========================================
- Hits 28414 28407 -7
- Misses 54748 54756 +8
Partials 2250 2250
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Checkmarx One â Scan Summary & Details â 20d9ccda-71d2-4534-9f49-663b19e8f0fb
Fixed Issues
| Severity | Issue | Source File / Package |
|---|---|---|
![]() |
Client_JQuery_Deprecated_Symbols | /libs/importer/src/services/import.service.ts: 459 |
