clients icon indicating copy to clipboard operation
clients copied to clipboard

[PM-12092] fix: Add new item should set item type

Open Chandra-Mauli-Sharma opened this issue 1 year ago â€ĸ 5 comments

đŸŽŸī¸ Tracking

Add new item should set item type (https://github.com/bitwarden/clients/issues/10994)

📔 Objective

Selecting an item type to filter by and then clicking on + (Add new item) should set the item type of the new item.

📸 Screenshots

image image

https://github.com/user-attachments/assets/2f0f4d7d-c16e-4adf-b802-9916c21296e1

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

đŸĻŽ Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or â„šī¸ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or âš ī¸ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or â™ģī¸ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

Chandra-Mauli-Sharma avatar Sep 14 '24 20:09 Chandra-Mauli-Sharma

Thank you for your contribution! We've added this to our internal Community PR board for review. ID: PM-12092

bitwarden-bot avatar Sep 14 '24 20:09 bitwarden-bot

This PR fixes #10994

Chandra-Mauli-Sharma avatar Sep 14 '24 21:09 Chandra-Mauli-Sharma

CLA assistant check
All committers have signed the CLA.

CLAassistant avatar Oct 17 '24 14:10 CLAassistant

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

:white_check_mark: Chandra-Mauli-Sharma
:x: cd-bitwarden
You have signed the CLA already but the status is still pending? Let us recheck it.

CLAassistant avatar Oct 17 '24 14:10 CLAassistant

Logo Checkmarx One – Scan Summary & Details – bd10f41a-a19f-4ede-a92c-05e28718718a

No New Or Fixed Issues Found

github-actions[bot] avatar Oct 17 '24 14:10 github-actions[bot]

@Chandra-Mauli-Sharma thank you for your patience and your contribution! QA has approved your change, and it will be going out in our next release. 😄

cd-bitwarden avatar Nov 12 '24 19:11 cd-bitwarden