clients icon indicating copy to clipboard operation
clients copied to clipboard

[SM-10995]-Removing feature flag

Open cd-bitwarden opened this issue 1 year ago â€ĸ 2 comments

đŸŽŸī¸ Tracking

📔 Objective

Remove feature flag vault-bulk-management-action

📸 Screenshots

None

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

đŸĻŽ Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or â„šī¸ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or âš ī¸ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or â™ģī¸ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

cd-bitwarden avatar Aug 29 '24 02:08 cd-bitwarden

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes missing coverage. Please review.

Project coverage is 35.14%. Comparing base (fc2c83f) to head (83d4a5c). Report is 39 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Files with missing lines Patch % Lines
...mponents/vault-items/vault-cipher-row.component.ts 0.00% 2 Missing :warning:
...lt/components/vault-items/vault-items.component.ts 0.00% 1 Missing :warning:
.../src/app/vault/individual-vault/vault.component.ts 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #10784      +/-   ##
==========================================
+ Coverage   35.13%   35.14%   +0.01%     
==========================================
  Files        2690     2690              
  Lines       83687    83660      -27     
  Branches    15897    15891       -6     
==========================================
- Hits        29403    29402       -1     
+ Misses      53318    53292      -26     
  Partials      966      966              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 29 '24 02:08 codecov[bot]

Logo Checkmarx One – Scan Summary & Details – ea9291b7-3b9e-4108-8818-fe06153691ef

No New Or Fixed Issues Found

github-actions[bot] avatar Aug 29 '24 02:08 github-actions[bot]

closing this PR as I had to open this PR again after changing the branch name :)

https://github.com/bitwarden/clients/pull/11000

cd-bitwarden avatar Sep 17 '24 14:09 cd-bitwarden