clients icon indicating copy to clipboard operation
clients copied to clipboard

[CL-278][CL-391] misc bit-item style fixes

Open willmartian opened this issue 1 year ago â€ĸ 3 comments

đŸŽŸī¸ Tracking

https://bitwarden.atlassian.net/browse/CL-278

https://bitwarden.atlassian.net/browse/CL-391

📔 Objective

bit-item misc style fixes:

  • use correct colors
  • use small icon button in stories
  • use pointer when hovering links/anchors

📸 Screenshots

See Storybook

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

đŸĻŽ Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or â„šī¸ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or âš ī¸ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or â™ģī¸ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

willmartian avatar Aug 28 '24 00:08 willmartian

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 32.87%. Comparing base (33c973d) to head (e68db41). Report is 28 commits behind head on ps/extension-refresh.

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files
@@                   Coverage Diff                    @@
##           ps/extension-refresh   #10758      +/-   ##
========================================================
- Coverage                 32.88%   32.87%   -0.01%     
========================================================
  Files                      2676     2676              
  Lines                     82212    82212              
  Branches                  15549    15549              
========================================================
- Hits                      27038    27031       -7     
- Misses                    53064    53071       +7     
  Partials                   2110     2110              

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 28 '24 00:08 codecov[bot]

Logo Checkmarx One – Scan Summary & Details – 6fe2bae8-9db9-4d9d-97a1-7e2fbdf3a3d3

No New Or Fixed Issues Found

github-actions[bot] avatar Aug 28 '24 00:08 github-actions[bot]

The ticket also mentions something about the gap between buttons, do we need to do anything there?

Nope! That must have been already fixed.

willmartian avatar Aug 28 '24 17:08 willmartian