clients icon indicating copy to clipboard operation
clients copied to clipboard

[deps] Platform: Update Rust crate security-framework to v2.11.1

Open renovate[bot] opened this issue 1 year ago • 4 comments

This PR contains the following updates:

Package Type Update Change
security-framework (source) dependencies patch =2.11.0 -> =2.11.1

Release Notes

kornelski/rust-security-framework (security-framework)

v2.11.1

Compare Source


Configuration

📅 Schedule: Branch creation - "every 2nd week starting on the 2 week of the year before 4am on Monday" (UTC), Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • [ ] If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

renovate[bot] avatar Aug 19 '24 01:08 renovate[bot]

⚠️ Artifact update problem

Renovate failed to update an artifact related to this branch. You probably do not want to merge this PR as-is.

♻ Renovate will retry this branch, including artifacts, only when one of the following happens:

  • any of the package files in this branch needs updating, or
  • the branch becomes conflicted, or
  • you click the rebase/retry checkbox if found above, or
  • you rename this PR's title to start with "rebase!" to trigger it manually

The artifact failure details are included below:

File name: apps/desktop/desktop_native/Cargo.lock
Command failed: cargo update --config net.git-fetch-with-cli=true --manifest-path apps/desktop/desktop_native/core/Cargo.toml --workspace
    Updating crates.io index
error: failed to select a version for `security-framework-sys`.
    ... required by package `security-framework v2.11.1`
    ... which satisfies dependency `security-framework = "=2.11.1"` of package `desktop_core v0.0.0 (/tmp/renovate/repos/github/bitwarden/clients/apps/desktop/desktop_native/core)`
    ... which satisfies path dependency `desktop_core` (locked to 0.0.0) of package `desktop_napi v0.0.0 (/tmp/renovate/repos/github/bitwarden/clients/apps/desktop/desktop_native/napi)`
versions that meet the requirements `^2.11.1` are: 2.12.0, 2.11.1

all possible versions conflict with previously selected packages.

  previously selected package `security-framework-sys v2.11.0`
    ... which satisfies dependency `security-framework-sys = "=2.11.0"` of package `desktop_core v0.0.0 (/tmp/renovate/repos/github/bitwarden/clients/apps/desktop/desktop_native/core)`
    ... which satisfies path dependency `desktop_core` (locked to 0.0.0) of package `desktop_napi v0.0.0 (/tmp/renovate/repos/github/bitwarden/clients/apps/desktop/desktop_native/napi)`

failed to select a version for `security-framework-sys` which could resolve this conflict

renovate[bot] avatar Aug 19 '24 01:08 renovate[bot]

Internal tracking:

  • ID: PM-11073
  • Link: https://bitwarden.atlassian.net/browse/PM-11073

bitwarden-bot avatar Aug 19 '24 01:08 bitwarden-bot

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 33.25%. Comparing base (9aeb412) to head (2b7cc3e). Report is 278 commits behind head on main.

:white_check_mark: All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #10560   +/-   ##
=======================================
  Coverage   33.25%   33.25%           
=======================================
  Files        2727     2727           
  Lines       85179    85179           
  Branches    16221    16221           
=======================================
  Hits        28326    28326           
  Misses      54598    54598           
  Partials     2255     2255           

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Aug 19 '24 01:08 codecov[bot]

Just noticed that renovate split the security-framework and security-framework-sys updates in two PRs: this one and https://github.com/bitwarden/clients/pull/10561.

So the break is because both versions need to be in sync, we should probably just add another group to the renovate config: https://github.com/bitwarden/clients/blob/a49f110fc2da49906a09152c1dd191d0f909c850/.github/renovate.json#L20-L21

dani-garcia avatar Aug 28 '24 09:08 dani-garcia