authenticator-ios icon indicating copy to clipboard operation
authenticator-ios copied to clipboard

[BWA-85] Add debug screen

Open KatherineInCode opened this issue 1 year ago â€ĸ 2 comments

đŸŽŸī¸ Tracking

https://bitwarden.atlassian.net/browse/BWA-85

📔 Objective

This adds a debug screen that can be opened with a shake or a triple-tap. It follows the pattern from PM, and is mostly reused code. As well, additional support code was brought in for ConfigService etc., though sections that would require an APIService aren't there yet. There are a number of candidates here for additional code-sharing between the two apps eventually.

📸 Screenshots

See diff.

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

đŸĻŽ Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or â„šī¸ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or âš ī¸ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or â™ģī¸ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

KatherineInCode avatar Oct 08 '24 19:10 KatherineInCode

Logo Checkmarx One – Scan Summary & Details – c7efab35-57bd-41a8-8edb-1146275a6030

No New Or Fixed Issues Found

github-actions[bot] avatar Oct 08 '24 20:10 github-actions[bot]

Codecov Report

Attention: Patch coverage is 57.70393% with 140 lines in your changes missing coverage. Please review.

Project coverage is 66.35%. Comparing base (23150d4) to head (68d0e94). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...hared/UI/Platform/Application/AppCoordinator.swift 0.00% 18 Missing :warning:
Authenticator/Application/SceneDelegate.swift 19.04% 17 Missing :warning:
...rShared/Core/Platform/Services/ConfigService.swift 77.02% 17 Missing :warning:
...orShared/Core/Platform/Services/StateService.swift 0.00% 17 Missing :warning:
...re/Platform/Services/Stores/AppSettingsStore.swift 15.00% 17 Missing :warning:
...Shared/Core/Platform/Models/Enum/FeatureFlag.swift 28.57% 15 Missing :warning:
...red/Core/Platform/Models/Domain/ServerConfig.swift 53.84% 12 Missing :warning:
AuthenticatorShared/UI/DebugMenu/ShakeWindow.swift 0.00% 11 Missing :warning:
...enticatorShared/UI/DebugMenu/DebugMenuModule.swift 0.00% 7 Missing :warning:
...ared/Core/Platform/Services/ServiceContainer.swift 0.00% 4 Missing :warning:
... and 2 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #166      +/-   ##
==========================================
- Coverage   66.59%   66.35%   -0.25%     
==========================================
  Files         202      211       +9     
  Lines        8879     9192     +313     
==========================================
+ Hits         5913     6099     +186     
- Misses       2966     3093     +127     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Oct 08 '24 20:10 codecov[bot]