authenticator-ios icon indicating copy to clipboard operation
authenticator-ios copied to clipboard

[BWA-39] Properly generate codes for search results

Open KatherineInCode opened this issue 1 year ago â€ĸ 2 comments

đŸŽŸī¸ Tracking

BWA-39

📔 Objective

This fixes a bug where search results weren't generating/refreshing TOTP codes properly.

📸 Screenshots

Simulator Screenshot - iPhone 15 Pro - 2024-06-13 at 15 43 14

⏰ Reminders before review

  • Contributor guidelines followed
  • All formatters and local linters executed and passed
  • Written new unit and / or integration tests where applicable
  • Protected functional changes with optionality (feature flags)
  • Used internationalization (i18n) for all UI strings
  • CI builds passed
  • Communicated to DevOps any deployment requirements
  • Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team

đŸĻŽ Reviewer guidelines

  • 👍 (:+1:) or similar for great changes
  • 📝 (:memo:) or â„šī¸ (:information_source:) for notes or general info
  • ❓ (:question:) for questions
  • 🤔 (:thinking:) or 💭 (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion
  • 🎨 (:art:) for suggestions / improvements
  • ❌ (:x:) or âš ī¸ (:warning:) for more significant problems or concerns needing attention
  • 🌱 (:seedling:) or â™ģī¸ (:recycle:) for future improvements or indications of technical debt
  • ⛏ (:pick:) for minor or nitpick changes

KatherineInCode avatar Jun 13 '24 20:06 KatherineInCode

Logo Checkmarx One – Scan Summary & Details – 8694e7e3-3dac-453f-a448-8e6a5e07c692

No New Or Fixed Issues Found

github-actions[bot] avatar Jun 13 '24 20:06 github-actions[bot]

Codecov Report

Attention: Patch coverage is 86.20690% with 8 lines in your changes missing coverage. Please review.

Project coverage is 65.99%. Comparing base (4cfe64f) to head (e4459ef). Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ared/Core/Platform/Services/ServiceContainer.swift 0.00% 4 Missing :warning:
...ult/Repositories/AuthenticatorItemRepository.swift 90.90% 3 Missing :warning:
...UI/Vault/ItemList/ItemList/ItemListProcessor.swift 94.73% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #119      +/-   ##
==========================================
+ Coverage   63.37%   65.99%   +2.61%     
==========================================
  Files         202      202              
  Lines        8685     8698      +13     
==========================================
+ Hits         5504     5740     +236     
+ Misses       3181     2958     -223     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Jun 17 '24 16:06 codecov[bot]