authenticator-ios
authenticator-ios copied to clipboard
[BWA-39] Properly generate codes for search results
đī¸ Tracking
đ Objective
This fixes a bug where search results weren't generating/refreshing TOTP codes properly.
đ¸ Screenshots
â° Reminders before review
- Contributor guidelines followed
- All formatters and local linters executed and passed
- Written new unit and / or integration tests where applicable
- Protected functional changes with optionality (feature flags)
- Used internationalization (i18n) for all UI strings
- CI builds passed
- Communicated to DevOps any deployment requirements
- Updated any necessary documentation (Confluence, contributing docs) or informed the documentation team
đĻŽ Reviewer guidelines
- đ (
:+1:) or similar for great changes - đ (
:memo:) or âšī¸ (:information_source:) for notes or general info - â (
:question:) for questions - đ¤ (
:thinking:) or đ (:thought_balloon:) for more open inquiry that's not quite a confirmed issue and could potentially benefit from discussion - đ¨ (
:art:) for suggestions / improvements - â (
:x:) or â ī¸ (:warning:) for more significant problems or concerns needing attention - đą (
:seedling:) or âģī¸ (:recycle:) for future improvements or indications of technical debt - â (
:pick:) for minor or nitpick changes
Checkmarx One â Scan Summary & Details â 8694e7e3-3dac-453f-a448-8e6a5e07c692
No New Or Fixed Issues Found
Codecov Report
Attention: Patch coverage is 86.20690% with 8 lines in your changes missing coverage. Please review.
Project coverage is 65.99%. Comparing base (
4cfe64f) to head (e4459ef). Report is 2 commits behind head on main.
Additional details and impacted files
@@ Coverage Diff @@
## main #119 +/- ##
==========================================
+ Coverage 63.37% 65.99% +2.61%
==========================================
Files 202 202
Lines 8685 8698 +13
==========================================
+ Hits 5504 5740 +236
+ Misses 3181 2958 -223
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.