distillery icon indicating copy to clipboard operation
distillery copied to clipboard

Fix -sname support

Open nifoc opened this issue 5 years ago • 1 comments

Summary of changes

-sname support was not working in all cases (e.g. https://github.com/bitwalker/distillery/issues/699). This fixes at least the things mentioned in the above issue.

Checklist

  • [ ] New functions have typespecs, changed functions were updated
  • [ ] Same for documentation, including moduledocs
  • [ ] Tests were added or updated to cover changes
  • [x] Commits were squashed into a single coherent commit

Licensing/Copyright

By submitting this PR, you agree to the following statement, please read before submission!

I certify that I own, and have sufficient rights to contribute, all source code and related material intended to be compiled or integrated with the source code for Distillery (the "Contribution"). My Contribution is licensed under the MIT License.

NOTE: If you submit a PR and remove the statement above, your PR will be rejected. For your PR to be considered, it must contain your agreement to license under the MIT license.

nifoc avatar Aug 27 '19 08:08 nifoc

Any news on this? I have the same problem being not able to ping or remote_console to my app with sname because of the inverted if statement in this PR

albertored avatar Oct 25 '19 07:10 albertored