Messages for collection verifying nft module

Open giorgionocera opened this issue 3 years ago • 4 comments

In the nft module, there is the nft/types/msgs.go file, which contains the messages. Here there exist two messages which are unused and should be removed:

TypeMsgVerifyCollection            = "verify_collection"
TypeMsgUnverifyCollection        = "unverify_collection"

Do you agree?

Oct 02 '22 16:10 giorgionocera

Yes - it was available on old design.

Oct 03 '22 03:10 ryusmo

Resolved on this commit https://github.com/bitsongofficial/go-bitsong/commit/3febed504e6e55be7ff3f16a2350da25f559b319

Please close the issue if things are okay @Giorgionocera

Oct 03 '22 03:10 ryusmo

This is also used in CLI flags. I think we should also remove it from there.

https://github.com/bitsongofficial/go-bitsong/blob/3febed504e6e55be7ff3f16a2350da25f559b319/x/nft/client/cli/flags.go#L107-L114

Do you agree?

Oct 03 '22 06:10 giorgionocera

i'm agree

Oct 06 '22 06:10 lukfm-mms