go-bitsong icon indicating copy to clipboard operation
go-bitsong copied to clipboard
verified publisher icon bitsongofficial

NFT naming

Open giorgionocera opened this issue 3 years ago • 1 comments

In the nft module, the word NFT is a very central one. It appears more than 1500 times. NFT stands for "Non-Fungible Tokens". For this reason, it should be written uppercase (NFT) or, in particular cases (like in development and code), it could be written all lowercase (nft). Even if it is only a matter of style and, for sure, it is not a problem (for this reason this issue should be considered as a low-priority one), I would replace all times the word is written as "Nft" in "NFT" or "nft".

An example is the method GetCollectionNfts https://github.com/bitsongofficial/go-bitsong/blob/84691c819214a1f9b9dd844ea2b49b7ccc8ece1b/x/nft/keeper/nft.go#L29

While other methods use the uppercase format like GetNFTsByOwner https://github.com/bitsongofficial/go-bitsong/blob/84691c819214a1f9b9dd844ea2b49b7ccc8ece1b/x/nft/keeper/nft.go#L10

What do you think about it?

giorgionocera avatar Sep 29 '22 11:09 giorgionocera

Okay - edition could be made

ryusmo avatar Sep 30 '22 17:09 ryusmo