go-bitsong icon indicating copy to clipboard operation
go-bitsong copied to clipboard

Query collection by Authority

Open giorgionocera opened this issue 3 years ago • 2 comments

In the nft module it could be useful to query the collections by authority. This would add the Collections query. Moreover, it could be useful to paginate the results (since they can become a large number).

An example of improving the collection query can be taken by the fantoken module.

Here is the FanTokens query definition. https://github.com/bitsongofficial/go-bitsong/blob/84691c819214a1f9b9dd844ea2b49b7ccc8ece1b/proto/bitsong/fantoken/v1beta1/query.proto#L22-L24

https://github.com/bitsongofficial/go-bitsong/blob/84691c819214a1f9b9dd844ea2b49b7ccc8ece1b/proto/bitsong/fantoken/v1beta1/query.proto#L39-L49

It could also be useful to provide results in cases like: https://marketplace/authority_address

What do you think about that?

giorgionocera avatar Sep 28 '22 14:09 giorgionocera

Yeah, can add collections query per collection owner. I think, all collections query could be added as well or when collection owner is empty, could return full collections.

ryusmo avatar Sep 28 '22 17:09 ryusmo

when collection owner is empty, could return full collections.

I prefer this approach 💪

giorgionocera avatar Oct 05 '22 09:10 giorgionocera