go-bitsong icon indicating copy to clipboard operation
go-bitsong copied to clipboard
verified publisher icon bitsongofficial

Suggestion for proto structure

Open giorgionocera opened this issue 3 years ago • 1 comments

It could be useful to separate the proto definitions in the nft module. At the moment, both the nft (and the side) definitions, the definition of the Params

https://github.com/bitsongofficial/go-bitsong/blob/84691c819214a1f9b9dd844ea2b49b7ccc8ece1b/proto/bitsong/nft/v1beta1/nft.proto#L74-L82

and the definition of the Events

https://github.com/bitsongofficial/go-bitsong/blob/84691c819214a1f9b9dd844ea2b49b7ccc8ece1b/proto/bitsong/nft/v1beta1/nft.proto#L84-L145

lay on the nft.proto file.

It could be useful to separate the definitions in different files (i.e., events.proto and params.proto), as it is done on the fantoken module. What do you think about that?

giorgionocera avatar Sep 28 '22 11:09 giorgionocera

It can be done like that.

ryusmo avatar Sep 28 '22 17:09 ryusmo