go-bitsong icon indicating copy to clipboard operation
go-bitsong copied to clipboard

Proposal Handler for NFT fees

Open giorgionocera opened this issue 3 years ago • 3 comments

In the nft module, it could be useful to add a new proposal handler to manage a custom proposal that could be used to change the NFTs issuing fees. An example of such a thing could be found in the fantoken module from line 54: https://github.com/bitsongofficial/go-bitsong/blob/84691c819214a1f9b9dd844ea2b49b7ccc8ece1b/x/fantoken/handler.go#L54-L80

giorgionocera avatar Sep 28 '22 10:09 giorgionocera

Yes, this is very useful

angelorc avatar Sep 28 '22 10:09 angelorc

Since nft issue fee is in params, it's not needed to add custom proposal, this can be done with ParamsUpdateProposal with nft subspace in it.

ryusmo avatar Sep 28 '22 17:09 ryusmo

the specific proposal handler is just a nice to have :) and could be implemented in an hour

we discussed it in our telegram group

angelorc avatar Sep 29 '22 11:09 angelorc