hazelcast-docker-swarm-discovery-spi icon indicating copy to clipboard operation
hazelcast-docker-swarm-discovery-spi copied to clipboard

Five refactorings

Open robinroos opened this issue 5 years ago • 2 comments

Five refactorings:

  • ”throws" declarations should not be superfluous
  • Static fields should not be updated in constructors (in this case the fields should not be static)
  • Unused "private" fields should be removed
  • Optimize Imports
  • Standard outputs should not be used directly to log anything (in this case suppress the warning since logging "to stdout" is the express purpose of the class SystemPrintLogger)

robinroos avatar Mar 19 '19 21:03 robinroos