hazelcast-docker-swarm-discovery-spi icon indicating copy to clipboard operation
hazelcast-docker-swarm-discovery-spi copied to clipboard

Published 20 hours ago • verified publisher icon bitsofinfo

Five refactorings

Open robinroos opened this issue 6 years ago • 2 comments

Five refactorings:

  • ”throws" declarations should not be superfluous
  • Static fields should not be updated in constructors (in this case the fields should not be static)
  • Unused "private" fields should be removed
  • Optimize Imports
  • Standard outputs should not be used directly to log anything (in this case suppress the warning since logging "to stdout" is the express purpose of the class SystemPrintLogger)

robinroos avatar Mar 19 '19 21:03 robinroos

The next set of refactorings is ready.

robinroos avatar Mar 21 '19 23:03 robinroos

Please just proceed with adding whatever other commits you have or are proposing to this PR if possible no need for a a bunch of different PRs if they are all just little things like this that are being dumped out of some automated code analyzer tool. thx

bitsofinfo avatar Mar 22 '19 20:03 bitsofinfo