Cameron Hart

Results 146 comments of Cameron Hart

Does https://docs.rs/glam/latest/glam/f32/struct.Quat.html#method.from_rotation_arc do what you are after? If it does, one thing that can be done is adding some metadata to docs so angle_between or between would find the quat...

It is possible to add doc aliases so if someone searches for something it will match the doc alias. For example there is a doc alias on length methods for...

I had to do some digging to work out when these were added, it was very early in glam's life https://github.com/bitshifter/glam-rs/commit/2e5ec772994e33e257e7aa5f85ec76d12cdd5656. I think they are fundamentally different because of the...

I want to try and understand how these are currently used by glam users since they aren't methods that I use myself, if possible, before making any changes. I can...

One way I could introduce this change would be to rename the 2D version as you have suggested here and not add a 2D `angle_between` until a later glam version....

Naming wise, there is currently a `Vec2::rotate_towards(self, rhs, max_angle)`, ~so I think `Vec2::angle_towards(self, rhs)` could match up with that~ edit, changed to `angle_to` on the basis that `rotate_towards` doesn't necessarily...

Thanks for taking this on! It looks like clippy is failing because perspective is unused in the tests you've added, from your comment above it sounded like you were intending...

> string_view will never be used because its C++11 I'm not suggesting that ImGui should use `string_view` and I haven't used it (or any other C++11) in this change. My...