bsips
bsips copied to clipboard
bitshares
BSIP 53: Detection of inbound Stealth transactions
Initial draft of BSIP 53, following discussion in #91 .
Hours estimated for this initial draft: 55, as per issue comment here.
Not sure if PR should include edits to table in README.md, so these are segregated into separate commits.
Not sure if PR should include edits to table in README.md, so these are segregated into separate commits.
It should, normally, although that often leads to conflicts.
Not the best place for this discussion, but: I have a task on my list to update the README.md file with the known BSIP identifiers, status and links. The thought is that the repo Maintainer will own that file and then the Authors can focus on their drafts within the PR. The README will link to the PR discussion until the BSIP draft is merged. Thoughts?
Would love to see this merged soon as an “initial draft.” Obviously, further refinements and additions will still need to follow in response to community feedback, thus while this PR may close, I presume that issue #91 will stay open as the discussion hub for this BSIP. But hopefully this initial draft can merge and be considered a “milestone”?
One item I’ll be working on very soon is doing some performance benchmarks to assess wallet efficiency in scanning network activity for owned transaction outputs. The basis of the scanning algorithm is recently implemented in a Kotlin library in the @Agorise repo here: https://github.com/Agorise/bitshares-stealth-k. Kotlin compiles to the Java Virtual Machine and this library is targeted towards smartphones.
I’ll be running the benchmarks on a 2014 MacBook Pro and on a Raspberry Pi to gauge how quickly a “day’s” worth of activity can be scanned on various hardware. I will make a table of results and post in issue #91 and eventually merge into the BSIP doc as part of the edits and revisions phase.
I estimate a few hours of work to run and tabulate these benchmarks.
I may follow that up with some investigations of strategies for increasing scanning performance.
Tagging: @ryanRfox
@MichelSantos — Thanks for the many great suggestions! I will take them all into consideration.