bitshares-ui icon indicating copy to clipboard operation
bitshares-ui copied to clipboard

Error in market limit order pricing calculation?

Open grctest opened this issue 1 year ago • 7 comments

Describe the bug

For user 'fkh2jevt` there are 2 open orders with price 0.00000 in the 'my open orders' section of the HONEST.USD_BTS market.

Also showing as 0.00000 price in the buy orders component.

To Reproduce

Navigate to this user's webapp view by searching for their name in the explorer, then go to the HONEST.USD_BTS market and view the my open orders and buy orders (show more orders to view).

Expected behavior

A price greater than 0 should be calculated.

Screenshots

image image

Additional info

https://blocksights.info/#/objects/1.7.456286605

grctest avatar Nov 30 '23 15:11 grctest

As @litepresence said in Telegram:

its not a calculation issue its just truncated for display

It's a UI issue. I don't think hiding the orders is a good idea. Maybe better show 0.0000> or something alike and if the user moves the mouse over it shows the full numbers. Also the 10M amount is too wide already.

abitmore avatar Nov 30 '23 17:11 abitmore

Good point, I have adapted to this issue in the astro ui as such:

image

grctest avatar Dec 03 '23 22:12 grctest

Good point, I have adapted to this issue in the astro ui as such:

Not bad. Just FYI I think in a financial system, numbers are better aligned with decimal points.

abitmore avatar Dec 03 '23 23:12 abitmore

OK I've changed the < min string to allow a greater quantity of decimal places as so: image

grctest avatar Dec 04 '23 11:12 grctest

OK I've changed the < min string to allow a greater quantity of decimal places as so

What if an order's price is 0.000000000000000000000000001, and another order's price is 100000000000000000000000.0, while typical orders' prices in that market are like 123.456789? :wink: In markets with few orders, prices vary widely. In popular markets where the first API call only returns the top X orders, the situation is different.

By the way the BTS amounts are not aligned with decimal points.

To be clear, I'm not being picky, and I know it takes a lot of effort to improve UX, finding a "good enough" solution is already very hard, let alone a "perfect" one. So please just do what you think is okay, and prioritize tasks appropriately.

Thank you anyway.

abitmore avatar Dec 04 '23 21:12 abitmore

By the way the BTS amounts are not aligned with decimal points.

What do you mean? Like the decimal point "." should be aligned like this?

image

I've adjusted the UX to show < min and on hover shows the real price with auto-adjusting width:

openOrders

grctest avatar Dec 05 '23 00:12 grctest

By the way the BTS amounts are not aligned with decimal points.

What do you mean? Like the decimal point "." should be aligned like this?

image

Yes.

abitmore avatar Dec 05 '23 01:12 abitmore