bitshares-ui icon indicating copy to clipboard operation
bitshares-ui copied to clipboard

Some old code of react is causing this warning, should we get rid of it sooner?

Open xiangxn opened this issue 2 years ago • 4 comments

Describe the bug Some old code of react is causing this warning, should we get rid of it sooner? image

To Reproduce Warning appears inside AssetSelectView component.

Expected behavior A clear and concise description of what you expected to happen.

Screenshots If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information):

  • OS: [e.g. iOS]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: [e.g. iPhone6]
  • OS: [e.g. iOS8.1]
  • Browser [e.g. stock browser, safari]
  • Version [e.g. 22]

Additional context Add any other context about the problem here.

xiangxn avatar Mar 07 '22 06:03 xiangxn

Yes, remove it if possible without exploding effort

sschiessl-bcp avatar Mar 09 '22 14:03 sschiessl-bcp

The modification of this is often relatively large, I hope there is not much code in the old way

xiangxn avatar Mar 10 '22 02:03 xiangxn

Hm, okay, not a priority imo

sschiessl-bcp avatar Mar 16 '22 09:03 sschiessl-bcp

Upgrading to react 18+ and uplifting to compatible packages would be a substantial effort workload.

grctest avatar Sep 22 '22 10:09 grctest