bitshares-ui icon indicating copy to clipboard operation
bitshares-ui copied to clipboard

[15] Gateway/Bridge Codebase Enhancements

Open startailcoon opened this issue 6 years ago • 6 comments

This issue is to track improvements to the Gateway and Bridge codebase.

Improvements are, but not limited to

  • [ ] Refactor Withdrawl/Deposit Modal
  • [ ] Refactor Bridge Modal

This task will not fix ANT components for the modals.

Rough estimate: 10-15 hours

Sub-Tasks

New Gateway API Drafting - #2477

Parent Task: https://github.com/bitshares/bitshares-ui/issues/1771

startailcoon avatar Oct 14 '18 19:10 startailcoon

@startailcoon is it in progress by you? i want to improve codebase

dot5enko avatar Nov 18 '18 21:11 dot5enko

@dot5enko if you feel you're up to the task, you can take over this one. I've haven't had time to start on it. There are some parts of the code that can be a little weird, as it was once built to handle only OpenLedger and Block Trades.

This should be refactored to be able to handle any new Bridge, and still be compatible with the way we are using today of course. This should also be using a settings file for bridges.

Gateways need a refreshment on the codebase, but was largely done before with the gateway settings file. Any improvements here would be better refactoring and easier to understand the code.

I'll keep working on the documentation part. If there are questions, I'm on Telegram 👍

startailcoon avatar Nov 20 '18 19:11 startailcoon

@startailcoon i'm a backend java developer with huge background in web previously (php, node, golang) so weird code is not a problem to me :) i'll try to do my best to set all things clear and tidy

dot5enko avatar Nov 20 '18 21:11 dot5enko

awesome 👍

startailcoon avatar Nov 21 '18 14:11 startailcoon

What is the branch you are working on for this @dot5enko ?

sschiessl-bcp avatar Aug 15 '19 08:08 sschiessl-bcp

hi @sschiessl-bcp. Changes will be in https://github.com/dot5enko/bitshares-ui/tree/2010_Gateway_Codebase_Improvements

dot5enko avatar Aug 15 '19 19:08 dot5enko