bitshares-core icon indicating copy to clipboard operation
bitshares-core copied to clipboard

Published 20 hours ago • verified publisher icon bitshares

Backport EOS patch about GELF 1.1 unstringified numbers

Open abitmore opened this issue 6 years ago • 3 comments

https://github.com/EOSIO/eos/commit/2d980b46a383f6cda346025cfbdc83185b7480ef

Note: I believe GELF logging is not used by default in BitShares, although node admins can try it.

Easy task but low priority.

abitmore avatar May 30 '18 13:05 abitmore

https://github.com/EOSIO/eos/pull/2458

It seems that if GELF is set up to use udp, a network "would_block" error could needlessly cause problems. The PR above should have fixed it in EOS. We should look at doing something similar.

This may deserve its own ticket, but placing it here until more research is completed.

Update: Created issue #1005 to track the GELF/udp issues.

jmjatlanta avatar May 30 '18 16:05 jmjatlanta

Related: https://github.com/EOSIO/eos/commit/b2be86055896d81fcffb88b9c992cacb3f9ddb44

pmconrad avatar May 30 '18 16:05 pmconrad

Related to udp would_block: https://github.com/EOSIO/eos/commit/9224efeaa8e47a124996c8e8f849ecd1eb85b224

pmconrad avatar May 30 '18 16:05 pmconrad