xchange-stream icon indicating copy to clipboard operation
xchange-stream copied to clipboard

Add failsafe integration test runner, rename integration tests

Open TSavo opened this issue 4 years ago • 3 comments

There are a number of integration tests which are presently ignored by the maven build. Rather than ignore them, this PR renames them to *IT.java, and adds the failsafe maven plugin, configuring it to not fail the build on a failed integration tests.

This paves the way for more integration tests without fear of failing the build if the exchange is down. The integration tests have been added to the following goals:

verify
integration-test

To run the tests, simply run mvn verify. To run only the integration tests, run mvn integration-test.

TSavo avatar Mar 04 '20 01:03 TSavo

This project is in the process of being merged into the XChange project and no further PRs will be merged here. Once the projects have been merged, there may be a short stabilization period where there will be large-scale renaming of classes and packages, which may cause conflicts. You are advised to wait at least a week from now and then resubmit your PR on the XChange project. Thank you for your support!

badgerwithagun avatar May 06 '20 17:05 badgerwithagun

@TSavo, I'm keen to get this done since it is an obvious difference between all the streaming modules and polling modules on XChange. Are you in a position to resubmit this PR on the XChange project?

badgerwithagun avatar May 08 '20 18:05 badgerwithagun

I will be in a few days, yes. :)

On Fri, May 8, 2020 at 11:02 AM Graham Crockford [email protected] wrote:

@TSavo https://github.com/TSavo, I'm keen to get this done since it is an obvious difference between all the streaming modules and polling modules on XChange. Are you in a position to resubmit this PR on the XChange project?

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/bitrich-info/xchange-stream/pull/540#issuecomment-625942349, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGWLJTNBPVB3NLQFSMUENTRQRCJ7ANCNFSM4LAYMXJQ .

TSavo avatar May 10 '20 06:05 TSavo