xchange-stream icon indicating copy to clipboard operation
xchange-stream copied to clipboard

[kraken] Exchange orderbook timestamp parse incorrect!

Open sudo168 opened this issue 5 years ago • 5 comments

The Kraken exchange orderbook timestamp is a seconds format since epoch. So need to multiply 1000. But this logic appear in two places:

One in: info.bitrich.xchangestream.kraken.KrakenOrderBookUtils

private static long timestampToMs(String timestamp) { return new BigDecimal(timestamp).multiply(new BigDecimal(1000)).longValue(); }

The other in: org.knowm.xchange.kraken.KrakenAdapters.adaptOrders(...)

sudo168 avatar Nov 14 '19 10:11 sudo168

@sudo168 Thank you for the issue. I have opend fix PR.

pchertalev avatar Nov 27 '19 11:11 pchertalev

I am good with this

mdvx avatar Dec 06 '19 16:12 mdvx

Have we fix this issue? If yes can we close it?

makarid avatar Dec 30 '19 10:12 makarid

I believe we can close it because PR is merged

pchertalev avatar Jan 08 '20 23:01 pchertalev

@badgerwithagun Bump for closing due to merged PR.

TSavo avatar Feb 28 '20 07:02 TSavo