Intro-To-Serverless icon indicating copy to clipboard operation
Intro-To-Serverless copied to clipboard

[Content Bug] Response for week 1 step 1

Open lechnerc77 opened this issue 3 years ago • 2 comments

Identify Steps:

  • Step _1

Week:

week 1

Describe the Issue

Branch Definition

The definition of a branch is not correct imho when it comes to the comparison with a fork

A fork is a copy of repository (including its branches) that can (but need not) be used to contribute to a project.

A branch is created within one repository with the goal to create another line of development that is isolated from the stable (main) branch. This enables the changes of code in an isolated environment without destabilizing the main branch.

Typo in Pull request Section

In the Pull request section there seems to be a "typo":

*You are basically asking for permission to "merge" your changes."

I guess the star as well as the last quotes are not needed.

Enhancement

Maybe a short description of the typical flow to sync your fork with the upstream repository via GitHub might be of value for the students:

Fetch + Merge upstream -> Pull changes to your local repo -> commit changes to branch -> psuh branch

Proposed Fix

  • Remove the comparison with a fork from the branch definition.
  • Correct typo
  • (Optional) Add GH Flow with forks

lechnerc77 avatar Apr 03 '22 13:04 lechnerc77

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

stale[bot] avatar Apr 18 '22 19:04 stale[bot]

@emsesc @ganning127 : Can we add the pinned label to the issues that should be done after the summer session so that they are ignored by the stale bot?

lechnerc77 avatar Apr 24 '22 09:04 lechnerc77