bitcore-wallet-service icon indicating copy to clipboard operation
bitcore-wallet-service copied to clipboard

Where is an upgraded client?

Open tomtruitt opened this issue 8 years ago • 17 comments

wallet create Alexandra 2-3 [info] Generating new keys [error] <ClientError:UPGRADE_NEEDED BWC clients < 1.2 are no longer supported.> ClientError { code: 'UPGRADE_NEEDED', message: 'BWC clients < 1.2 are no longer supported.' }

tomtruitt avatar Sep 30 '16 13:09 tomtruitt

https://github.com/bitpay/bitcore-wallet-client

dabura667 avatar Sep 30 '16 15:09 dabura667

That's the client library... In the readme it point to a CLI client. Is there no command line client that's supported any longer?

tomtruitt avatar Sep 30 '16 15:09 tomtruitt

The client in the readme is listed as https://github.com/bitpay/bitcore-wallet

tomtruitt avatar Sep 30 '16 15:09 tomtruitt

current CLI at the link you provided requires 2.3.1 of BWC, so you should not see error message about <1.2

Upgrade your bitcore-wallet

dabura667 avatar Oct 01 '16 13:10 dabura667

Yes you'll see from the title of my issue I don't know how. I cloned bitcore-wallet and yesterday and received this error.

tomtruitt avatar Oct 01 '16 13:10 tomtruitt

did you perform npm install in the cloned directory? nodejs packages need to run install to install the required dependencies... perhaps you have an old version of BWC on your system.

dabura667 avatar Oct 01 '16 13:10 dabura667

I'm confused the version at the link i sent is clearly labelled 0.6.1

tomtruitt avatar Oct 01 '16 14:10 tomtruitt

The error you sent 'BWC clients < 1.2 are no longer supported.' means that your instance of bitcore-wallet is using an old version of bitcore-wallet-client. If you look at the most recent version of bitcore-wallet, the dependencies are stated as follows. (Check package.json)

  "dependencies": {
    "bitcore-wallet-client": "git://github.com/bitpay/bitcore-wallet-client#41abd4fd6365db083cda9d305978121a03e86d6e",
    "commander": "^2.6.0",
    "lodash": "^3.3.1",
    "moment": "^2.9.0",
    "npmlog": "^1.2.0",
    "qr-image": "^3.1.0",
    "read": "^1.0.5",
    "sjcl": "^1.0.2"
  },

You can view the source for the commit noted at this link: https://github.com/bitpay/bitcore-wallet-client/tree/41abd4fd6365db083cda9d305978121a03e86d6e

If you check package.json for bitcore-wallet-client at this commit, it says

"version": "2.3.1",

So just to test it out, I just ran:

$ git clone https://github.com/bitpay/bitcore-wallet
$ cd bitcore-wallet
$ npm install
$ grep "\"version\":" node_modules/bitcore-wallet-client/package.json
>  "version": "2.3.1",

dabura667 avatar Oct 01 '16 15:10 dabura667

yes my version of BWC is also 2.3.1

you'll notice the error says "BWC clients" under version 1.2 are no longer supported... the command line client https://github.com/bitpay/bitcore-wallet is listed as 0.6.1

tomtruitt avatar Oct 01 '16 17:10 tomtruitt

BWC client is referring to bitcore-wallet-client. I know this for a fact because I have been following all these repos for over a year and I know why this error was created.

bitcore-wallet-client version 1.2 included code that breaks compatibility with <1.2 versions.

The error message has nothing to do with bitcore-wallet, even if you made your own CLI wallet software, if you use <1.2 bitcore-wallet-client, you will get this message.

dabura667 avatar Oct 02 '16 10:10 dabura667

Well according to what you are saying what is happening should not be. The language looks pretty clear. This error should be rewritten at the least because it says bwc client. Regardless i cloned both repos yesterday 2 days ago on a brand new digital ocean droplet with node and npm installed and bwc reports the latest version

tomtruitt avatar Oct 02 '16 11:10 tomtruitt

Are you able to use the command line client bitcore-wallet?

tomtruitt avatar Oct 02 '16 11:10 tomtruitt

$ git clone https://github.com/bitpay/bitcore-wallet
$ cd bitcore-wallet
$ npm install
$ grep "\"version\":" node_modules/bitcore-wallet-client/package.json
>  "version": "2.3.1",

Try this. I literally did this just now and got no error.

dabura667 avatar Oct 02 '16 13:10 dabura667

I have done that without errors too. However as my op stated when attempting the wallet create command I receive the version error listed.

tomtruitt avatar Oct 02 '16 14:10 tomtruitt

Change

npm install

to

npm install -g .

Don't forget the period.

The wallet command is from the globally installed bitcore-wallet, you are not using the bitcore-wallet you cloned.

dabura667 avatar Oct 03 '16 03:10 dabura667

Ok that makes sense I'll try that thank you!

tomtruitt avatar Oct 03 '16 11:10 tomtruitt

bitcore-wallet-client in bitcore-wallet's dependencies version too low. If you not use it globally just use in your project try following:

  • rm -rf /YOURPROJECT_PATH/node_modules/bitcore-wallet-client #delete low version dependency
  • npm install bitcore-wallet-client --save #reinstall bitcore-wallet-client ,v4.4.0 works for me

esseak avatar Dec 15 '16 11:12 esseak