bitcore-mnemonic icon indicating copy to clipboard operation
bitcore-mnemonic copied to clipboard

[Ready for testing] Fix validation to look for any wordlist with a valid checksum

Open dabura667 opened this issue 9 years ago • 3 comments

Fixes https://github.com/bitpay/copay/issues/3211 and will allow for wordlists that have common words in different positions.

This fix will be especially necessary if zh_CN and zh_TW wordlists will both be supported someday, as they have many words in common.

for reference, here are 3 mnemonics only using the common words between English and French. This will help in testing.

English check OK:
abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon angle
French check OK:
abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon brave
both check OK:
abandon abandon abandon abandon abandon abandon abandon abandon abandon abandon amateur double

dabura667 avatar Sep 22 '15 00:09 dabura667

Interesting find!

maraoz avatar Sep 22 '15 00:09 maraoz

Ready for testing / merge if all is fine.

dabura667 avatar Sep 22 '15 01:09 dabura667

bump

dabura667 avatar May 07 '16 11:05 dabura667