bitcore-lib icon indicating copy to clipboard operation
bitcore-lib copied to clipboard

Published 20 hours ago • verified publisher icon bitpay

Fix double import breakage

Open Stilldabomb opened this issue 6 years ago • 6 comments

Fixed problem where it would break on double import, causing the program to crash saying there can only be one instance.

Stilldabomb avatar Mar 25 '18 09:03 Stilldabomb

Okay, this is actually done now as far as I can tell.

Stilldabomb avatar Mar 25 '18 10:03 Stilldabomb

@Stilldabomb this will done when you fix instanceof problem: https://github.com/bitpay/bitcore/pull/1165

fanatid avatar Mar 25 '18 10:03 fanatid

@fanatid this would fix that issue, as the classes grabbed by libraries self-depending on bitcore-lib will be the global bitcore library, which would be whichever one is generated first. I could add some version checking in there to make sure the versions are the same?

Stilldabomb avatar Mar 25 '18 10:03 Stilldabomb

@fanatid

image

Stilldabomb avatar Mar 25 '18 10:03 Stilldabomb

Added conflict check so old versions don't silently break.

image

Stilldabomb avatar Mar 25 '18 11:03 Stilldabomb

@fanatid nothing?

Stilldabomb avatar Apr 01 '18 02:04 Stilldabomb