bitcoind-rpc icon indicating copy to clipboard operation
bitcoind-rpc copied to clipboard

Published 20 hours ago • verified publisher icon bitpay

Readme.md example code requires bitcore

Open bochap opened this issue 7 years ago • 3 comments

It looks like line var bitcore = require('bitcore'); in the Readme.md example is unused. Should that be removed. I can put in the PR

bochap avatar Jan 29 '18 18:01 bochap

Looking at this more should if be using bitcore-library instead of bitcore.

bochap avatar Jan 30 '18 16:01 bochap

@seetd It seems to me that these days the "bitcore" package just exports the contents of the "bitcore-lib" package https://github.com/bitpay/bitcore/blob/95dc8b291089e2dec814d9a762df2ea341edef40/index.js So either way works fine. You're right though that "bitcore-lib" is probably "more right".

carnesen avatar Jan 31 '18 14:01 carnesen

That's true. The reason I brought that back up was bitcore encompasses a lot more than bitcore-lib. So I thought that making it use bitcore-lib will be more modular if you are not using bitcore. I would be glad to create a PR for that if no one disagrees with that.

bochap avatar Jan 31 '18 15:01 bochap