bitnom

> > Only the changes already included in the PR > > Are you saying that this PR won't cause any other lines of code in the repo to be...

> Can you please write tests for the new code added? should be good now

> Thanks for the PR! I think this is very much inline with the custom client effort @olgavrou is doing also with the discussion @davorrunje and I had in #1227....

I presume somebody is going to ask me to write a test here. I have been using the PR with success for a few days, and will add a test...

For anyone coming here from other PRs/issues looking for various forms of overrides and hooks, it looks like the major effort for that will be: https://github.com/microsoft/autogen/pull/1240

> @bitnom There have been many recent changes e.g., the custom client and recent work on streming #1551. Do you still want to pursue this PR? I'll be getting back...

This might be the best pr of the repo rn. It's a better direction than the simple observers I've been using. It will be exciting to hook all methods. Expanding...

I've started down this path now. Here are some preliminary references in-case anyone is interested in existing implementations: https://pypi.org/project/middleware/ https://pypi.org/project/observer-hooks/ https://pypi.org/project/func-hooks/ https://pypi.org/project/better-hooks no repo so I pushed to: https://github.com/bitnom/better-hooks then...

> With this, we could add @hookable_method to https://github.com/microsoft/autogen/blob/main/autogen/oai/client.py#L416 to hook up what coming to and from LLM, right?... > > ref: #1146 for sure. We could actually decorate literally...

> Yes, i saw that other PR too. I like, IMHO, this generic hook aproach as lets you decouple logic from the base-code. > > Maybe, one would even ENABLE_HOOKS="logging,other_ones",...