containers icon indicating copy to clipboard operation
containers copied to clipboard

Tagging for stable releases [bitnami/milvus]

Open roszkowski opened this issue 10 months ago • 4 comments

Name and Version

[bitnami/milvus1:2.3.13]

What is the problem this feature will solve?

Hello!

I've been checking multiple images and once I actually use them in my helm chart and deploy - all seem to have "-dev" suffix once I log to them into attu. It raises questions that I couldn't answer myself.

What is the latest non-dev version of bitnami/milvus?

What is the feature you are proposing to solve the problem?

I would propose adding appropriate status to release tag names like "-dev" or "-beta" to avoid unnecessary checks.

roszkowski avatar Apr 24 '24 15:04 roszkowski

That shouldn't be the case since we don't provide dev, alpha, beta, etc code. In the case of Milvus and Attu, we fetch the source code from the upstream repos, at this moment the latest source code was obtained from https://github.com/milvus-io/milvus/releases/tag/v2.4.0 and https://github.com/zilliztech/attu/releases/tag/v2.3.10 respectively.

How are you obtaining that dev suffix?

carrodher avatar Apr 25 '24 08:04 carrodher

@carrodher thanks for reply. I get it in attu once I log in there: image

and this is what I provide in values.yaml:

milvus:
  image:
    tag: 2.3.11

I think I tried all in range beteen 2.3.12 and 2.3.9 and for all of them it had "dev" in it.

my attu version is: 2.3.10, but it acted the same in 2.3.0

roszkowski avatar Apr 25 '24 08:04 roszkowski

Can you see the same without setting a specific tag? I mean, removing the image.tag block from the values.yaml

carrodher avatar Apr 25 '24 08:04 carrodher

@carrodher yes it was the case as well, that's why I started checking other versions

roszkowski avatar Apr 25 '24 08:04 roszkowski

Hi I can reproduce the issue. For instance, with the Bitnami chart milvus:7.0.0:

$ helm install milvus oci://registry-1.docker.io/bitnamicharts/milvus --version 7.0.0 -f .vib/milvus/runtime-parameters.yaml

image

The version can also be observed in the logs:

$ kubectl logs deploy/milvus-proxy milvus | grep '^Version:'
Version:   v2.3.12-dev

The issue should be fixed with the next release of milvus 2.4.1 (release still in progress):

$ milvus run proxy
...
Version:   v2.4.1

andresbono avatar May 07 '24 12:05 andresbono

The new version 2.4.1 does not contain the dev tag. Container has been released and chart should be out in a few minutes.

dgomezleon avatar May 08 '24 07:05 dgomezleon