containers icon indicating copy to clipboard operation
containers copied to clipboard

[bitnami/kubectl] Add `envsubst` to kubectl Docker image

Open djschny opened this issue 1 year ago • 2 comments

Description of the change

This changes adds envsubst to the kubectl image.

Benefits

This helps when using using kubernetes manifests that have values that change depending upon the environment situation. It is fairly common to do something like the following:

export SERVER_URL="my-prod-server"
envsubst < my-manifest.yaml | kubectl apply -f -

Possible drawbacks

It increases the image size a bit (I believe about 100K).

Applicable issues

Additional information

This was already done/raised for #34957

djschny avatar Jan 26 '24 12:01 djschny

Hi @djschny,

Apart from the comment I added here, I will create a new internal task to verify the availability of this package in the rest of the distributions we offer as part of the Tanzu Application Catalog.

In the meantime, we recommend you to extend our base image with your required RUN action to install the gettext-base package.

gongomgra avatar Jan 31 '24 16:01 gongomgra

Requested changes made.

djschny avatar Feb 20 '24 23:02 djschny

@gongomgra is there anything else I need to change to get this moving?

djschny avatar Apr 01 '24 12:04 djschny

Hi @djschny,

Sorry for the delay. I have been checking this and I have found we are adding the gettext package instead of gettext-base in other images like appsmith. Can you please update your PR? I don't have any other suggestion/requirement to this.

gongomgra avatar Apr 02 '24 07:04 gongomgra

Sorry @djschny, I have just noticed your changes are for an old version of the Dockerfiles based on debian-11, but we have recently updated the base image to debian-12. I have added the gettext package for the next image revision, so I'm closing this PR. Sorry for the inconveniences.

gongomgra avatar Apr 02 '24 08:04 gongomgra

New images have been released including the gettext system package

https://github.com/bitnami/containers/tree/main/bitnami/kubectl/1.27/debian-12

gongomgra avatar Apr 02 '24 09:04 gongomgra