containers icon indicating copy to clipboard operation
containers copied to clipboard

[bitnami/keycloak] Remove builtin metrics from stacksmith

Open kamontat opened this issue 1 year ago • 7 comments

Name and Version

bitnami/keycloak:22.0.3

What is the problem this feature will solve?

Currently Keycloak package generated from stacksmith, contains built-in keycloak-metrics-spi-4.0.0, which is nice for most case. However, on my case I needs to customize and uses our internal metrics SPI, which conflict with what provides by keycloak-metrics-spi provider.

To prove my word:

  1. Download Keycloak from stacksmith-keycloak (noted that this link is from here
  2. Untar the result
  3. Navigated to ./files/keycloak/providers/ after untar
  4. You will see keycloak-metrics-spi-4.0.0.jar file

What is the feature you are proposing to solve the problem?

Remove built-ins providers and download on build-time instead.

What alternatives have you considered?

No response

kamontat avatar Sep 26 '23 10:09 kamontat

Hi,

Did you try mounting your own jar file overriding the existing one?

javsalgar avatar Sep 27 '23 09:09 javsalgar

@javsalgar Yes, it works. But it seem to be just temporary solution.

kamontat avatar Sep 28 '23 12:09 kamontat

If you need to modify the default SPI metrics provided by keycloak, you can either do this or create your own fork, as this seems to be a very specific use case not taken into account by keycloak devs if I'm not mistaken.

javsalgar avatar Sep 29 '23 07:09 javsalgar

@javsalgar keycloak-metrics-spi-4.0.0.jar is not a SPI provided by Keycloak, it actually a third-party metrics from https://github.com/aerogear/keycloak-metrics-spi.

kamontat avatar Oct 02 '23 02:10 kamontat

Would it make sense to have an environment variable to disable the included metrics spi?

javsalgar avatar Oct 02 '23 08:10 javsalgar

@javsalgar Yes, if possible.

kamontat avatar Oct 05 '23 07:10 kamontat

Hi @kamontat ,

We have created a task for your proposal. We will let you know about any updates.

dgomezleon avatar Oct 09 '23 06:10 dgomezleon