containers
containers copied to clipboard
bitnami
[bitnami/discourse] Use unicorn instead of passenger
Original https://github.com/bitnami/bitnami-docker-discourse/pull/234
discourse lately removed the setting from the UI, this image doesn't really work properly without disabling this option currently.
Signed-off-by: Tobias Gurtzick [email protected]
right now requires to set serve_static_assets = true
important info from previous ticket:
the docker-compose seems to be outdated and deviates from the helm chart. The helm chart sets already
- DISCOURSE_PORT_NUMBER=8080
- DISCOURSE_EXTERNAL_HTTP_PORT_NUMBER=80
These two variables, and adding those to the docker-compose lets it run just fine.
@migruiz4, as you have more context than me with this PR and it looks like you have already started checking the changes in the associated issue, I'm handling it over to you so you can take the best decision.
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.
![github-actions[bot] avatar](https://avatars.githubusercontent.com/in/15368?v=4 "Published by a pub.dev verified publisher"){kind=small}
Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary.
i guess not @prathamesh-gharat. It does not have any priority for me right now since I use our image instead, if you want you can look into @migruiz4 comments
so @migruiz4 is this end of the line? bitnami will stay with a broken version? Or is there any chance to get this merged.
The PR was reviewed but there is pending to implement some of the suggestions
there were no valid suggestions @carrodher
Please review again, runit is needed, without the container is crashing
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.
Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary.
How are you doing with the PR? Can it be merged? There are also massive performance problems here, which are probably caused by passenger.
this stuff is unmaintained. If I were you I would look elsewhere.
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.
@migruiz4 Can I assume that you will pick up this PR eventually? I need this PR merged as well. If nobody is picking this one up, I'd try, but I am lacking a lot of context here so I would rather not do it.
Hi @jacobowitz,
We have an internal task to study if migrating bitnami/unicorn from passenger to unicorn is viable or not, but as we have to deal with other priorities it is currently in our Backlog.
As I mentioned in my review, the usage of runit in our images is a strong no from my side.
This Pull Request has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thank you for your contribution.
Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Pull Request. Do not hesitate to reopen it later if necessary.