charts icon indicating copy to clipboard operation
charts copied to clipboard

[bitnami/external-dns] Add targetLabels option to ServiceMonitor

Open mrrsm opened this issue 1 year ago • 1 comments

Description of the change

Enables the ability to specify podTargetLabels and targetLabels on ServiceMonitor definitions to forward labels on prometheus

Benefits

Increased granularity on metrics

Possible drawbacks

Applicable issues

  • fixes #29332

Additional information

Checklist

  • [X] Chart version bumped in Chart.yaml according to semver. This is not necessary when the changes only affect README.md files.
  • [X] Variables are documented in the values.yaml and added to the README.md using readme-generator-for-helm
  • [X] Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
  • [X] All commits signed off and in agreement of Developer Certificate of Origin (DCO)

mrrsm avatar Oct 08 '24 19:10 mrrsm

@migruiz4 it looks like the CI needs to rerun as it got stuck but didn't seem to have any errors. Is there a way for you to rerun or does it just need another commit?

mrrsm avatar Oct 15 '24 13:10 mrrsm

@migruiz4 I've rebased since the last release, can you re-review please?

mrrsm avatar Oct 28 '24 20:10 mrrsm