[bitnami/opensearch] Enable automated setup of snapshot policies
Description of the change
This change lets users opt-in to automatically initialize snapshot repositories and snapshot policies in OpenSearch using a post-install chart hook.
Benefits
Before this change, configuring snapshot policies was a fairly complex task that requires interacting with the OpenSearch API manually. This change automates that process and allows for easy configuration via the Helm chart's values. I believe this will enable more people to have an OpenSearch instance that is properly configured so consistent backups can be taken.
Possible drawbacks
Considering this is an opt-in feature, I don't see any significant draw-backs.
Applicable issues
- fixes #29601
Additional information
I've tried to split the PR into logically separate commits, so if we want the PVC creation to be a separate PR that's easy to do. Please inspect my commits for more info!
Checklist
- [x] Chart version bumped in
Chart.yamlaccording to semver. This is not necessary when the changes only affect README.md files. - [x] Variables are documented in the values.yaml and added to the
README.mdusing readme-generator-for-helm - [x] Title of the pull request follows this pattern [bitnami/<name_of_the_chart>] Descriptive title
- [x] All commits signed off and in agreement of Developer Certificate of Origin (DCO)
Sorry for the delay in getting back to you. This is just a quick message to let you know that we are going to review it and will provide feedback as soon as possible.
Thanks, I really appreciate the ping to let me know you will get to it soon! 👍
Please take a look at the error while generating the README
error=Please ensure all *.registry params include the [default: REGISTRY_NAME] modifier in the chart bitnami/opensearch/values.yaml file
Please take a look at the error while generating the README
error=Please ensure all *.registry params include the [default: REGISTRY_NAME] modifier in the chart bitnami/opensearch/values.yaml file
I'm aware of the error. It relates to this discussion: https://github.com/bitnami/charts/pull/29796#discussion_r1819152621
If we want to go for keeping the API body as YAML format, do you have any idea how we should go about configuring the @param argument for the documentation?
Just updated the thread above. Please ping me with a new comment when you update the PR. Thanks
Great. I'll just run one last test by installing it in my local cluster to try and verify nothing is obviously broken. I'll ping you once I'm done with that.
I found a typo in the Network Policy that I fixed. When debugging this, I also added a flag to curl to make debugging things a lot easier when curl crashes.
I've tested this now and it seems to work! Assuming you approve my recent changes, I think we are ready to merge! 🚀
Hey @jotamartos , if you have time to check on my latest changes that would be great. 🙂
After merging main I'm getting a CI error I don't believe I got before:
Is this a new check? I have no idea where to find the images warning list or why it's wrong.
EDIT: Think I found it! Pushing an attempt to fix it.
@jotamartos I've resolved the conflicts now. If you could have a look at the latest changes and review before the next conflict emerge, that would be awesome! 👍
Oh happy day! 🎉 Thank you for the collaboration!