charts icon indicating copy to clipboard operation
charts copied to clipboard

[bitnami/apisix] Enable admission webhook at ingress controller

Open vladimirpetr opened this issue 1 year ago • 2 comments

Name and Version

bitnami/apisix 3.3.5

What is the problem this feature will solve?

Utilising admission webhook with custom resources is vital.

Currently, when enabling APISIX ingress controller, its configuration does not enable admission webhook through kubernetes.enable_admission. As a result, the admission webhook is not enabled, although the ingress controller container as well as its service open the corresponding ports (8443 and 443, respectively). Connecting to these ports result in a connection refused error.

Furthermore, optional creating a ValidatingWebhookConfiguration for the admission webhook should be made available.

What is the feature you are proposing to solve the problem?

  • Add configuration parameter kubernetes.enable_admissionin the controller's configuration, set to true by default (corresponding ports are already open)
  • Add an option to create a ValidatingWebhookConfiguration for the admission webhook in the values file

What alternatives have you considered?

  • Using the ingressController.extraConfig field to set the configuration parameter
  • Creating a ValidatingWebhookConfiguration by means of the extraDeploy field

vladimirpetr avatar Aug 09 '24 11:08 vladimirpetr

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

github-actions[bot] avatar Aug 28 '24 01:08 github-actions[bot]

Thanks @vladimirpetr for using bitnami/charts and bringing this issue to our attention. We appreciate your involvement!

I think this is an interesting feature and I think you have very clear how to add it. Would you like to contribute with a pull request?. The Bitnami team is excited to review your submission and offer feedback. You can find the contributing guidelines here.

Your contribution will greatly benefit the community.

fmulero avatar Aug 28 '24 09:08 fmulero

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

github-actions[bot] avatar Sep 13 '24 01:09 github-actions[bot]

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Issue. Do not hesitate to reopen it later if necessary.

github-actions[bot] avatar Sep 18 '24 01:09 github-actions[bot]